headless: Avoid copies for string parameters in DevTools bindings

headless/lib/browser/devtools_api/client_api_generator.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import argparse
 import collections
 import os.path
 import re
 import sys
 try:
@@ skipping 174 matching lines @@
       'to_raw_type': '*%s',
       'to_raw_return_type': '%s.get()',
       'to_pass_type': 'std::move(%s)',
       'type': 'std::unique_ptr<base::Value>',
       'raw_type': 'base::Value',
       'raw_pass_type': 'base::Value*',
       'raw_return_type': 'const base::Value*',
   }
 
 
-def CreateStringTypeDefinition(domain):
+def CreateStringTypeDefinition():
   return {
       'return_type': 'std::string',
       'pass_type': 'const std::string&',
       'to_pass_type': '%s',
       'to_raw_type': '%s',
       'to_raw_return_type': '%s',
       'type': 'std::string',
       'raw_type': 'std::string',
       'raw_pass_type': 'const std::string&',
       'raw_return_type': 'std::string',
   }
 
 
 def CreatePrimitiveTypeDefinition(type):
   typedefs = {
       'number': 'double',
       'integer': 'int',
       'boolean': 'bool',
-      'string': 'std::string',
   }
   return {
       'return_type': typedefs[type],
       'pass_type': typedefs[type],
       'to_pass_type': '%s',
       'to_raw_type': '%s',
       'to_raw_return_type': '%s',
       'type': typedefs[type],
       'raw_type': typedefs[type],
       'raw_pass_type': typedefs[type],
       'raw_return_type': typedefs[type],
   }
 
 
 type_definitions = {}
 type_definitions['number'] = CreatePrimitiveTypeDefinition('number')
 type_definitions['integer'] = CreatePrimitiveTypeDefinition('integer')
 type_definitions['boolean'] = CreatePrimitiveTypeDefinition('boolean')
-type_definitions['string'] = CreatePrimitiveTypeDefinition('string')
+type_definitions['string'] = CreateStringTypeDefinition()
 type_definitions['object'] = CreateObjectTypeDefinition()
 type_definitions['any'] = CreateAnyTypeDefinition()
 
 
 def WrapArrayDefinition(type):
   return {
       'return_type': 'std::vector<%s>' % type['type'],
       'pass_type': 'std::vector<%s>' % type['type'],
       'to_raw_type': '%s',
       'to_raw_return_type': '&%s',
@@ skipping 21 matching lines @@
         items_type = type['items']['type']
         type_definitions[domain['domain'] + '.' + type['id']] = (
             WrapArrayDefinition(type_definitions[items_type]))
       elif 'enum' in type:
         type_definitions[domain['domain'] + '.' + type['id']] = (
             CreateEnumTypeDefinition(domain['domain'], type))
         type['$ref'] = domain['domain'] + '.' + type['id']
       elif type['type'] == 'any':
         type_definitions[domain['domain'] + '.' + type['id']] = (
             CreateAnyTypeDefinition())
+      elif type['type'] == 'string':
+        type_definitions[domain['domain'] + '.' + type['id']] = (
+            CreateStringTypeDefinition())
       else:
         type_definitions[domain['domain'] + '.' + type['id']] = (
             CreatePrimitiveTypeDefinition(type['type']))
 
 
 def TypeDefinition(name):
   return type_definitions[name]
 
 
 def ResolveType(property):
@@ skipping 212 matching lines @@
   InitializeDomainDependencies(json_api)
   PatchExperimentalCommandsAndEvents(json_api)
   EnsureCommandsHaveParametersAndReturnTypes(json_api)
   SynthesizeCommandTypes(json_api)
   SynthesizeEventTypes(json_api)
   PatchFullQualifiedRefs(json_api)
   CreateTypeDefinitions(json_api)
   GenerateDomains(jinja_env, output_dirname, json_api)
   GenerateTypes(jinja_env, output_dirname, json_api)
   GenerateTypeConversions(jinja_env, output_dirname, json_api)