Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: build/android/lint/suppressions.xml

Issue 2862603002: Move Android resource_zip files into own build subdir. (Closed)
Patch Set: Move Android resource_zip files into own build subdir. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | build/config/android/rules.gni » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <?xml version="1.0" encoding="utf-8"?> 1 <?xml version="1.0" encoding="utf-8"?>
2 <lint> 2 <lint>
3 <!-- 3 <!--
4 STOP! It looks like you want to suppress some lint errors: 4 STOP! It looks like you want to suppress some lint errors:
5 - Have you tried identifing the offending patch? 5 - Have you tried identifing the offending patch?
6 Ask the author for a fix and/or revert the patch. 6 Ask the author for a fix and/or revert the patch.
7 - It is preferred to add suppressions in the code instead of 7 - It is preferred to add suppressions in the code instead of
8 sweeping it under the rug here. See: 8 sweeping it under the rug here. See:
9 9
10 http://developer.android.com/tools/debugging/improving-w-lint.html 10 http://developer.android.com/tools/debugging/improving-w-lint.html
(...skipping 125 matching lines...) Expand 10 before | Expand all | Expand 10 after
136 </issue> 136 </issue>
137 <issue id="IconMissingDensityFolder"> 137 <issue id="IconMissingDensityFolder">
138 <!-- see crbug.com/542435 --> 138 <!-- see crbug.com/542435 -->
139 <ignore regexp="android_webview/apk/java/res"/> 139 <ignore regexp="android_webview/apk/java/res"/>
140 <ignore regexp="android_webview/tools/system_webview_shell/apk/res"/> 140 <ignore regexp="android_webview/tools/system_webview_shell/apk/res"/>
141 <ignore regexp="chrome/android/webapk/shell_apk/res"/> 141 <ignore regexp="chrome/android/webapk/shell_apk/res"/>
142 <ignore regexp="chromecast/internal"/> 142 <ignore regexp="chromecast/internal"/>
143 <ignore regexp="tools/android/push_apps_to_background/res"/> 143 <ignore regexp="tools/android/push_apps_to_background/res"/>
144 </issue> 144 </issue>
145 <issue id="ImpliedQuantity" severity="Error"> 145 <issue id="ImpliedQuantity" severity="Error">
146 <ignore regexp="gen/chrome/android/chrome_strings_grd"/> 146 <ignore regexp="chrome/android/chrome_strings_grd"/>
147 </issue> 147 </issue>
148 <issue id="InconsistentArrays" severity="Error"> 148 <issue id="InconsistentArrays" severity="Error">
149 <ignore regexp="gen/android_webview/locale_paks.resources.zip/values/locale- paks.xml"/> 149 <ignore regexp="android_webview/locale_paks.resources.zip/values/locale-paks .xml"/>
150 <ignore regexp="gen/chrome/android/chrome_locale_paks.resources.zip/values/l ocale-paks.xml"/> 150 <ignore regexp="chrome/android/chrome_locale_paks.resources.zip/values/local e-paks.xml"/>
151 </issue> 151 </issue>
152 <issue id="InconsistentLayout" severity="ignore"/> 152 <issue id="InconsistentLayout" severity="ignore"/>
153 <issue id="InefficientWeight" severity="Error"> 153 <issue id="InefficientWeight" severity="Error">
154 <ignore regexp="android_webview/tools/system_webview_shell/apk/res/layout/ac tivity_webview_browser.xml"/> 154 <ignore regexp="android_webview/tools/system_webview_shell/apk/res/layout/ac tivity_webview_browser.xml"/>
155 </issue> 155 </issue>
156 <issue id="InflateParams" severity="ignore"/> 156 <issue id="InflateParams" severity="ignore"/>
157 <issue id="InlinedApi" severity="ignore"/> 157 <issue id="InlinedApi" severity="ignore"/>
158 <issue id="InvalidPackage" severity="Error"> 158 <issue id="InvalidPackage" severity="Error">
159 <ignore regexp="espresso/espresso_core_java.interface.jar"/> 159 <ignore regexp="espresso/espresso_core_java.interface.jar"/>
160 </issue> 160 </issue>
(...skipping 73 matching lines...) Expand 10 before | Expand all | Expand 10 after
234 <ignore regexp="com/android/webview/chromium/ServiceWorkerSettingsAdapter.cl ass"/> 234 <ignore regexp="com/android/webview/chromium/ServiceWorkerSettingsAdapter.cl ass"/>
235 <!-- TODO(crbug.com/635567): Fix this properly. --> 235 <!-- TODO(crbug.com/635567): Fix this properly. -->
236 <ignore regexp="org/chromium/chrome/browser/ChromeActivity.class"/> 236 <ignore regexp="org/chromium/chrome/browser/ChromeActivity.class"/>
237 <!-- TODO(crbug.com/635567): Fix this properly. --> 237 <!-- TODO(crbug.com/635567): Fix this properly. -->
238 <ignore regexp="org/chromium/chrome/browser/ChromeTabbedActivity.class"/> 238 <ignore regexp="org/chromium/chrome/browser/ChromeTabbedActivity.class"/>
239 </issue> 239 </issue>
240 <issue id="PackageManagerGetSignatures"> 240 <issue id="PackageManagerGetSignatures">
241 <ignore regexp="chrome/android/webapk/libs/client/src/org/chromium/webapk/li b/client/WebApkValidator.java"/> 241 <ignore regexp="chrome/android/webapk/libs/client/src/org/chromium/webapk/li b/client/WebApkValidator.java"/>
242 </issue> 242 </issue>
243 <issue id="PluralsCandidate" severity="Error"> 243 <issue id="PluralsCandidate" severity="Error">
244 <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-e n-rGB/android_chrome_strings.xml"/> 244 <ignore regexp="chrome/android/chrome_strings_grd.resources.zip/values-en-rG B/android_chrome_strings.xml"/>
245 <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values/a ndroid_chrome_strings.xml"/> 245 <ignore regexp="chrome/android/chrome_strings_grd.resources.zip/values/andro id_chrome_strings.xml"/>
246 </issue> 246 </issue>
247 <issue id="Recycle" severity="ignore"/> 247 <issue id="Recycle" severity="ignore"/>
248 <issue id="Registered" severity="ignore"/> 248 <issue id="Registered" severity="ignore"/>
249 <issue id="ResourceType" severity="Error"> 249 <issue id="ResourceType" severity="Error">
250 <ignore regexp="/javatests/"/> 250 <ignore regexp="/javatests/"/>
251 </issue> 251 </issue>
252 <issue id="RtlCompat" severity="ignore"/> 252 <issue id="RtlCompat" severity="ignore"/>
253 <issue id="RtlEnabled" severity="ignore"/> 253 <issue id="RtlEnabled" severity="ignore"/>
254 <issue id="RtlSymmetry" severity="ignore"/> 254 <issue id="RtlSymmetry" severity="ignore"/>
255 <issue id="SdCardPath"> 255 <issue id="SdCardPath">
256 <ignore regexp="content/public/android/java/src/org/chromium/content/browser /MediaResourceGetter.java"/> 256 <ignore regexp="content/public/android/java/src/org/chromium/content/browser /MediaResourceGetter.java"/>
257 </issue> 257 </issue>
258 <issue id="SetJavaScriptEnabled" severity="ignore"/> 258 <issue id="SetJavaScriptEnabled" severity="ignore"/>
259 <issue id="SignatureOrSystemPermissions" severity="ignore"/> 259 <issue id="SignatureOrSystemPermissions" severity="ignore"/>
260 <issue id="SpUsage" severity="Error"> 260 <issue id="SpUsage" severity="Error">
261 <ignore regexp="chromecast/internal"/> 261 <ignore regexp="chromecast/internal"/>
262 </issue> 262 </issue>
263 <issue id="StringFormatCount" severity="Error"> 263 <issue id="StringFormatCount" severity="Error">
264 <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-c s/android_chrome_strings.xml"/> 264 <ignore regexp="chrome/android/chrome_strings_grd.resources.zip/values-cs/an droid_chrome_strings.xml"/>
265 <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-p l/android_chrome_strings.xml"/> 265 <ignore regexp="chrome/android/chrome_strings_grd.resources.zip/values-pl/an droid_chrome_strings.xml"/>
266 <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values/a ndroid_chrome_strings.xml"/> 266 <ignore regexp="chrome/android/chrome_strings_grd.resources.zip/values/andro id_chrome_strings.xml"/>
267 </issue> 267 </issue>
268 <issue id="StringFormatInvalid" severity="Error"> 268 <issue id="StringFormatInvalid" severity="Error">
269 <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-c s/android_chrome_strings.xml"/> 269 <ignore regexp="chrome/android/chrome_strings_grd.resources.zip/values-cs/an droid_chrome_strings.xml"/>
270 <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-d a/android_chrome_strings.xml"/> 270 <ignore regexp="chrome/android/chrome_strings_grd.resources.zip/values-da/an droid_chrome_strings.xml"/>
271 <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-p l/android_chrome_strings.xml"/> 271 <ignore regexp="chrome/android/chrome_strings_grd.resources.zip/values-pl/an droid_chrome_strings.xml"/>
272 <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-p t-rBR/android_chrome_strings.xml"/> 272 <ignore regexp="chrome/android/chrome_strings_grd.resources.zip/values-pt-rB R/android_chrome_strings.xml"/>
273 <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-s v/android_chrome_strings.xml"/> 273 <ignore regexp="chrome/android/chrome_strings_grd.resources.zip/values-sv/an droid_chrome_strings.xml"/>
274 <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-t l/android_chrome_strings.xml"/> 274 <ignore regexp="chrome/android/chrome_strings_grd.resources.zip/values-tl/an droid_chrome_strings.xml"/>
275 </issue> 275 </issue>
276 <issue id="TextFields" severity="Error"> 276 <issue id="TextFields" severity="Error">
277 <ignore regexp="chromecast/internal"/> 277 <ignore regexp="chromecast/internal"/>
278 </issue> 278 </issue>
279 <issue id="TypographyDashes" severity="Error"> 279 <issue id="TypographyDashes" severity="Error">
280 <ignore regexp="chrome/app/policy/android/values-v21/restriction_values.xml" /> 280 <ignore regexp="chrome/app/policy/android/values-v21/restriction_values.xml" />
281 </issue> 281 </issue>
282 <!-- Typos check disabled due to lint bug: http://crbug.com/671170 --> 282 <!-- Typos check disabled due to lint bug: http://crbug.com/671170 -->
283 <issue id="Typos" severity="ignore" /> 283 <issue id="Typos" severity="ignore" />
284 <issue id="UnusedAttribute" severity="ignore"/> 284 <issue id="UnusedAttribute" severity="ignore"/>
285 <issue id="UnusedIds" severity="ignore"/> 285 <issue id="UnusedIds" severity="ignore"/>
286 <issue id="UnusedQuantity" severity="Error"> 286 <issue id="UnusedQuantity" severity="Error">
287 <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-c s/android_chrome_strings.xml"/> 287 <ignore regexp="chrome/android/chrome_strings_grd.resources.zip/values-cs/an droid_chrome_strings.xml"/>
288 <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-i n/android_chrome_strings.xml"/> 288 <ignore regexp="chrome/android/chrome_strings_grd.resources.zip/values-in/an droid_chrome_strings.xml"/>
289 <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-j a/android_chrome_strings.xml"/> 289 <ignore regexp="chrome/android/chrome_strings_grd.resources.zip/values-ja/an droid_chrome_strings.xml"/>
290 <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-k o/android_chrome_strings.xml"/> 290 <ignore regexp="chrome/android/chrome_strings_grd.resources.zip/values-ko/an droid_chrome_strings.xml"/>
291 <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-l t/android_chrome_strings.xml"/> 291 <ignore regexp="chrome/android/chrome_strings_grd.resources.zip/values-lt/an droid_chrome_strings.xml"/>
292 <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-s k/android_chrome_strings.xml"/> 292 <ignore regexp="chrome/android/chrome_strings_grd.resources.zip/values-sk/an droid_chrome_strings.xml"/>
293 <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-t h/android_chrome_strings.xml"/> 293 <ignore regexp="chrome/android/chrome_strings_grd.resources.zip/values-th/an droid_chrome_strings.xml"/>
294 <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-v i/android_chrome_strings.xml"/> 294 <ignore regexp="chrome/android/chrome_strings_grd.resources.zip/values-vi/an droid_chrome_strings.xml"/>
295 <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-z h-rCN/android_chrome_strings.xml"/> 295 <ignore regexp="chrome/android/chrome_strings_grd.resources.zip/values-zh-rC N/android_chrome_strings.xml"/>
296 <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-z h-rTW/android_chrome_strings.xml"/> 296 <ignore regexp="chrome/android/chrome_strings_grd.resources.zip/values-zh-rT W/android_chrome_strings.xml"/>
297 </issue> 297 </issue>
298 <!-- TODO(crbug.com/635567): Fix this properly. --> 298 <!-- TODO(crbug.com/635567): Fix this properly. -->
299 <issue id="UnusedResources" severity="ignore"/> 299 <issue id="UnusedResources" severity="ignore"/>
300 <issue id="UnusedResources"> 300 <issue id="UnusedResources">
301 <ignore regexp="PRODUCT_DIR/gen/remoting/android/remoting_android_raw_resour ces/res/raw/credits.html"/> 301 <ignore regexp="PRODUCT_DIR/gen/remoting/android/remoting_android_raw_resour ces/res/raw/credits.html"/>
302 <ignore regexp="PRODUCT_DIR/gen/remoting/android/remoting_android_raw_resour ces/res/raw/credits_css.css"/> 302 <ignore regexp="PRODUCT_DIR/gen/remoting/android/remoting_android_raw_resour ces/res/raw/credits_css.css"/>
303 <ignore regexp="PRODUCT_DIR/gen/remoting/android/remoting_android_raw_resour ces/res/raw/credits_js.js"/> 303 <ignore regexp="PRODUCT_DIR/gen/remoting/android/remoting_android_raw_resour ces/res/raw/credits_js.js"/>
304 <ignore regexp="PRODUCT_DIR/gen/remoting/android/remoting_android_raw_resour ces/res/raw/main.css"/> 304 <ignore regexp="PRODUCT_DIR/gen/remoting/android/remoting_android_raw_resour ces/res/raw/main.css"/>
305 <ignore regexp="android_ui_strings.xml"/> 305 <ignore regexp="android_ui_strings.xml"/>
306 <ignore regexp="android_webview/java/res/drawable-hdpi/ic_play_circle_outlin e_black_48dp.png"/> 306 <ignore regexp="android_webview/java/res/drawable-hdpi/ic_play_circle_outlin e_black_48dp.png"/>
(...skipping 29 matching lines...) Expand all
336 <ignore regexp="chrome/android/java/res/drawable-hdpi/progress_bar_backgroun d_white.9.png"/> 336 <ignore regexp="chrome/android/java/res/drawable-hdpi/progress_bar_backgroun d_white.9.png"/>
337 <ignore regexp="chrome/android/java/res/drawable-hdpi/shortcut_incognito.png "/> 337 <ignore regexp="chrome/android/java/res/drawable-hdpi/shortcut_incognito.png "/>
338 <ignore regexp="chrome/android/java/res/drawable-hdpi/shortcut_newtab.png"/> 338 <ignore regexp="chrome/android/java/res/drawable-hdpi/shortcut_newtab.png"/>
339 <ignore regexp="chrome/android/java/res/drawable-hdpi/signin_promo_illustrat ion.png"/> 339 <ignore regexp="chrome/android/java/res/drawable-hdpi/signin_promo_illustrat ion.png"/>
340 <ignore regexp="chrome/android/java/res/drawable-nodpi/missing.png"/> 340 <ignore regexp="chrome/android/java/res/drawable-nodpi/missing.png"/>
341 <ignore regexp="chrome/android/java/res/values-v17/styles.xml"/> 341 <ignore regexp="chrome/android/java/res/values-v17/styles.xml"/>
342 <ignore regexp="chromecast/browser/android/apk/res/values/strings.xml"/> 342 <ignore regexp="chromecast/browser/android/apk/res/values/strings.xml"/>
343 <ignore regexp="chromecast/internal"/> 343 <ignore regexp="chromecast/internal"/>
344 <ignore regexp="clank"/> 344 <ignore regexp="clank"/>
345 <ignore regexp="content/shell/android/java/res/mipmap-hdpi/app_icon.png"/> 345 <ignore regexp="content/shell/android/java/res/mipmap-hdpi/app_icon.png"/>
346 <ignore regexp="gen/android_webview/locale_paks.resources.zip/*"/> 346 <ignore regexp="android_webview/locale_paks.resources.zip/*"/>
347 <ignore regexp="gen/android_webview/strings_grd.resources.zip/values/android _webview_strings.xml"/> 347 <ignore regexp="android_webview/strings_grd.resources.zip/values/android_web view_strings.xml"/>
348 <ignore regexp="gen/components/strings/components_strings_grd.resources.zip/ values.*/components_strings.xml"/> 348 <ignore regexp="components/strings/components_strings_grd.resources.zip/valu es.*/components_strings.xml"/>
349 <ignore regexp="gen/remoting/resources/strings_java.resources.zip/values/rem oting_strings.xml"/> 349 <ignore regexp="remoting/resources/strings_java.resources.zip/values/remotin g_strings.xml"/>
350 <ignore regexp="remoting/android/java/res/drawable-hdpi/ic_backspace.png"/> 350 <ignore regexp="remoting/android/java/res/drawable-hdpi/ic_backspace.png"/>
351 <ignore regexp="remoting/android/java/res/drawable-hdpi/ic_cardboard.png"/> 351 <ignore regexp="remoting/android/java/res/drawable-hdpi/ic_cardboard.png"/>
352 <ignore regexp="remoting/android/java/res/drawable-hdpi/ic_voice_input.png"/ > 352 <ignore regexp="remoting/android/java/res/drawable-hdpi/ic_voice_input.png"/ >
353 <ignore regexp="remoting/android/java/res/drawable-hdpi/ic_zoom_in.png"/> 353 <ignore regexp="remoting/android/java/res/drawable-hdpi/ic_zoom_in.png"/>
354 <ignore regexp="remoting/android/java/res/drawable-hdpi/ic_zoom_out.png"/> 354 <ignore regexp="remoting/android/java/res/drawable-hdpi/ic_zoom_out.png"/>
355 <ignore regexp="remoting/android/java/res/layout/navigation_list_item.xml"/> 355 <ignore regexp="remoting/android/java/res/layout/navigation_list_item.xml"/>
356 <ignore regexp="remoting/android/java/res/mipmap-hdpi/logo_remote_desktop_la uncher.png"/> 356 <ignore regexp="remoting/android/java/res/mipmap-hdpi/logo_remote_desktop_la uncher.png"/>
357 <ignore regexp="remoting/android/java/res/values-v17/styles.xml"/> 357 <ignore regexp="remoting/android/java/res/values-v17/styles.xml"/>
358 <!-- Used by Android's policies system --> 358 <!-- Used by Android's policies system -->
359 <ignore regexp="restriction_values.xml"/> 359 <ignore regexp="restriction_values.xml"/>
(...skipping 102 matching lines...) Expand 10 before | Expand all | Expand 10 after
462 <ignore regexp="chrome/android/javatests"/> 462 <ignore regexp="chrome/android/javatests"/>
463 <ignore regexp="/test/"/> 463 <ignore regexp="/test/"/>
464 </issue> 464 </issue>
465 <issue id="WrongCall" severity="ignore"/> 465 <issue id="WrongCall" severity="ignore"/>
466 <issue id="WrongConstant"> 466 <issue id="WrongConstant">
467 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/SSLClien tCertificateRequest.java"/> 467 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/SSLClien tCertificateRequest.java"/>
468 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/payments /ui/EditorView.java"/> 468 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/payments /ui/EditorView.java"/>
469 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/signin/S igninAndSyncView.java"/> 469 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/signin/S igninAndSyncView.java"/>
470 </issue> 470 </issue>
471 </lint> 471 </lint>
OLDNEW
« no previous file with comments | « no previous file | build/config/android/rules.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698