Allow autotest extension to access system.display

Allow autotest extension to access system.display

system.display is currently only allowed for a few cases.  Grant
autotest extension to use the API for test purpose, too.

TEST=autotest works
BUG=712705
Review-Url: https://codereview.chromium.org/2862223003
Cr-Commit-Position: refs/heads/master@{#470124}
Committed: https://chromium.googlesource.com/chromium/src/+/84b76aa34b7ee89ea7b44af59239f6729aa53ab5

[victorhsieh0, 2017-05-05 22:14:55]

victorhsieh@google.com changed reviewers:
+ stevenjb@chromium.org, victorhsieh@google.com

[victorhsieh0, 2017-05-05 22:14:55]

Steven, PTAL.

[stevenjb, 2017-05-08 17:20:08]

The way we do this is a bit wonky, but this lgtm for now anyway.

[victorhsieh0, 2017-05-08 18:22:03]

The CQ bit was checked by victorhsieh@google.com

[commit-bot: I haz the power, 2017-05-08 18:23:06]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-08 21:08:38]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1494267723167410, "parent_rev":
"1510abbfe7ba6d200cfcc0f461c5a38c761fa353", "commit_rev":
"84b76aa34b7ee89ea7b44af59239f6729aa53ab5"}

[commit-bot: I haz the power, 2017-05-08 21:08:54]

Description was changed from

==========
Allow autotest extension to access system.display

system.display is currently only allowed for a few cases.  Grant
autotest extension to use the API for test purpose, too.

TEST=autotest works
BUG=712705
==========

to

==========
Allow autotest extension to access system.display

system.display is currently only allowed for a few cases.  Grant
autotest extension to use the API for test purpose, too.

TEST=autotest works
BUG=712705

Review-Url: https://codereview.chromium.org/2862223003
Cr-Commit-Position: refs/heads/master@{#470124}
Committed:
https://chromium.googlesource.com/chromium/src/+/84b76aa34b7ee89ea7b44af59239...
==========

[commit-bot: I haz the power, 2017-05-08 21:08:57]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/84b76aa34b7ee89ea7b44af59239...

[afakhry, 2017-05-10 01:06:12]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2874633002/ by afakhry@chromium.org.

The reason for reverting is: This causes display settings to crash whenever you
attempt to change anything. It assumes this is used from an extension..

[afakhry, 2017-05-10 01:08:02]

On 2017/05/10 01:06:12, afakhry wrote:
> A revert of this CL (patchset #1 id:1) has been created in
> https://codereview.chromium.org/2874633002/ by mailto:afakhry@chromium.org.
> 
> The reason for reverting is: This causes display settings to crash whenever
you
> attempt to change anything. It assumes this is used from an extension..

I meant it causes Chrome crash.

[stevenjb, 2017-05-10 16:15:08]

https://codereview.chromium.org/2862223003/diff/1/extensions/browser/api/syst...
File extensions/browser/api/system_display/system_display_api.cc (right):

https://codereview.chromium.org/2862223003/diff/1/extensions/browser/api/syst...
extensions/browser/api/system_display/system_display_api.cc:180: if
(extension()->permissions_data()->HasAPIPermission(
Ugh, I should have noticed that this needs to be if (extension() && ....)