Allow autotest extension to access system.display

extensions/browser/api/system_display/system_display_api.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/browser/api/system_display/system_display_api.h"
 
 #include <map>
 #include <memory>
 #include <set>
 #include <string>
 
 #include "base/macros.h"
 #include "base/memory/ptr_util.h"
 #include "build/build_config.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/browser/web_contents_observer.h"
 #include "extensions/browser/api/system_display/display_info_provider.h"
 #include "extensions/common/api/system_display.h"
+#include "extensions/common/permissions/permissions_data.h"
 
 #if defined(OS_CHROMEOS)
 #include "extensions/common/manifest_handlers/kiosk_mode_info.h"
 #endif
 
 namespace extensions {
 
 namespace display = api::system_display;
 
 const char SystemDisplayFunction::kCrosOnlyError[] =
@@ skipping 139 matching lines @@
   if (source_context_type() == Feature::WEBUI_CONTEXT)
     return true;
   if (KioskModeInfo::IsKioskEnabled(extension()))
     return true;
   *error = kKioskOnlyError;
   return false;
 #endif
 }
 
 bool SystemDisplayFunction::ShouldRestrictToKioskAndWebUI() {
+  // Allow autotest extension to access for Chrome OS testing.
+  if (extension()->permissions_data()->HasAPIPermission(

[stevenjb, 2017/05/10 16:15:08]

Ugh, I should have noticed that this needs to be if (extension() && ....)

+      APIPermission::kAutoTestPrivate)) {
+    return false;
+  }
   return true;
 }
 
 ExtensionFunction::ResponseAction SystemDisplayGetInfoFunction::Run() {
   std::unique_ptr<display::GetInfo::Params> params(
       display::GetInfo::Params::Create(*args_));
   bool single_unified = params->flags && params->flags->single_unified &&
                         *params->flags->single_unified;
   DisplayInfoProvider::DisplayUnitInfoList all_displays_info =
       DisplayInfoProvider::Get()->GetAllDisplaysInfo(single_unified);
@@ skipping 152 matching lines @@
   std::string error;
   if (DisplayInfoProvider::Get()->IsNativeTouchCalibrationActive(&error))
     return RespondNow(Error(error));
 
   if (!DisplayInfoProvider::Get()->ClearTouchCalibration(params->id, &error))
     return RespondNow(Error(error));
   return RespondNow(NoArguments());
 }
 
 }  // namespace extensions