Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(645)

Issue 2874633002: Revert of Allow autotest extension to access system.display (Closed)

Created:
3 years, 7 months ago by afakhry
Modified:
3 years, 7 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, waihong
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Allow autotest extension to access system.display (patchset #1 id:1 of https://codereview.chromium.org/2862223003/ ) Reason for revert: This causes a Chrome crash whenever you attempt to change anything in display settings. It assumes this is used from an extension. Original issue's description: > Allow autotest extension to access system.display > > system.display is currently only allowed for a few cases. Grant > autotest extension to use the API for test purpose, too. > > TEST=autotest works > BUG=712705 > > Review-Url: https://codereview.chromium.org/2862223003 > Cr-Commit-Position: refs/heads/master@{#470124} > Committed: https://chromium.googlesource.com/chromium/src/+/84b76aa34b7ee89ea7b44af59239f6729aa53ab5 TBR=stevenjb@chromium.org,victorhsieh@google.com,victorhsieh@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=712705, 719804 Review-Url: https://codereview.chromium.org/2874633002 Cr-Commit-Position: refs/heads/master@{#470461} Committed: https://chromium.googlesource.com/chromium/src/+/04b4874993cea9341a2d3446bcc486f52916477c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M extensions/browser/api/system_display/system_display_api.cc View 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
afakhry
Created Revert of Allow autotest extension to access system.display
3 years, 7 months ago (2017-05-10 01:06:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2874633002/1
3 years, 7 months ago (2017-05-10 01:07:39 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet; ...
3 years, 7 months ago (2017-05-10 03:10:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2874633002/1
3 years, 7 months ago (2017-05-10 03:56:40 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-10 04:50:24 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/04b4874993cea9341a2d3446bcc4...

Powered by Google App Engine
This is Rietveld 408576698