Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2860903002: web_dev_style: tweak varNamesLikeThis check to detect endsWithUnder_ (Closed)

Created:
3 years, 7 months ago by Dan Beam
Modified:
3 years, 7 months ago
Reviewers:
dpapad
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

web_dev_style: tweak varNamesLikeThis check to detect endsWithUnder_ R=dpapad@chromium.org BUG=582027 Review-Url: https://codereview.chromium.org/2860903002 Cr-Commit-Position: refs/heads/master@{#469252} Committed: https://chromium.googlesource.com/chromium/src/+/3b974ce1f81433615cb6fd03a6435dcb7a3a852c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M chrome/browser/web_dev_style/js_checker.py View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/web_dev_style/js_checker_test.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Dan Beam
3 years, 7 months ago (2017-05-04 01:25:54 UTC) #1
dpapad
On 2017/05/04 at 01:25:54, dbeam wrote: > LGTM. Ultimately I think those checks belong to ...
3 years, 7 months ago (2017-05-04 02:40:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2860903002/1
3 years, 7 months ago (2017-05-04 02:42:45 UTC) #4
commit-bot: I haz the power
3 years, 7 months ago (2017-05-04 02:52:21 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3b974ce1f81433615cb6fd03a643...

Powered by Google App Engine
This is Rietveld 408576698