Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 2589333004: WebUI: Experimenting with ESLint, WIP. (Closed)

Created:
4 years ago by dpapad
Modified:
3 years, 7 months ago
Reviewers:
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

WebUI: Experimenting with ESLint, WIP. cd chrome/browser/resources/ npm install -g gulp npm install #Show errors gulp lint --filter=settings gulp lint --filter=print_preview # Show errors and fix auto-fixable errors gulp lint --filter=settings --fix gulp lint --filter=print_preview --fix BUG=None CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Patch Set 1 #

Patch Set 2 : More rules #

Patch Set 3 : More setup #

Patch Set 4 : Add missing dep #

Patch Set 5 : Remove gulp-eslint, make --fix work. #

Patch Set 6 : Relax rules for now, to make existing code pass. #

Patch Set 7 : Relax rules #

Patch Set 8 : More relaxing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -0 lines) Patch
A chrome/browser/resources/.eslintrc.js View 1 2 3 4 5 6 7 1 chunk +29 lines, -0 lines 0 comments Download
A chrome/browser/resources/gulpfile.js View 1 2 3 4 1 chunk +22 lines, -0 lines 0 comments Download
A chrome/browser/resources/package.json View 1 2 4 1 chunk +10 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (10 generated)
rbpotter
3 years, 7 months ago (2017-05-05 00:47:32 UTC) #8

          

Powered by Google App Engine
This is Rietveld 408576698