chrome/browser/web_dev_style/js_checker_test.py - Issue 2860903002: web_dev_style: tweak varNamesLikeThis check to detect endsWithUnder_

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/web_dev_style/js_checker_test.py

Issue 2860903002: web_dev_style: tweak varNamesLikeThis check to detect endsWithUnder_ (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/web_dev_style/js_checker_test.py

diff --git a/chrome/browser/web_dev_style/js_checker_test.py b/chrome/browser/web_dev_style/js_checker_test.py

index b9ea46bf46f8b7c22f736341a1e030d4ae320a80..1f0fea79ef918839992e0c901eec02b632098de1 100755

--- a/chrome/browser/web_dev_style/js_checker_test.py

+++ b/chrome/browser/web_dev_style/js_checker_test.py

@@ -370,6 +370,7 @@ class JsCheckerTest(SuperMoxTestBase):

def testVarNameFails(self):

lines = [

"var private_;",

+ "var hostName_ = 'https://google.com';",

" var _super_private",

" var unix_hacker = someFunc();",

]

« no previous file with comments | « chrome/browser/web_dev_style/js_checker.py ('k') | no next file » | no next file with comments »