Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 2860593002: Prune ComputeVisibleSelectionInDOMTreeDeprecated from FrameSelection::SelectAll (Closed)

Created:
3 years, 7 months ago by Xiaocheng
Modified:
3 years, 7 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Prune ComputeVisibleSelectionInDOMTreeDeprecated from FrameSelection::SelectAll This patch prunes a call site of the the deprecated function. The change is safe because FrameSelection::SelectAll is only reachable from ExecuteSelectAll, where layout is already clean. BUG=698633 TEST=n/a; no behavioral change Review-Url: https://codereview.chromium.org/2860593002 Cr-Commit-Position: refs/heads/master@{#469947} Committed: https://chromium.googlesource.com/chromium/src/+/07775ad85062bd6c858fbe553f0e56b34026b5cb

Patch Set 1 #

Patch Set 2 : Fix unit test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M third_party/WebKit/Source/core/editing/FrameSelection.cpp View 1 1 chunk +4 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 21 (15 generated)
Xiaocheng
PTAL.
3 years, 7 months ago (2017-05-08 02:48:12 UTC) #11
yosin_UTC9
lgtm
3 years, 7 months ago (2017-05-08 03:29:14 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2860593002/20001
3 years, 7 months ago (2017-05-08 03:29:26 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/420361)
3 years, 7 months ago (2017-05-08 04:46:38 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2860593002/20001
3 years, 7 months ago (2017-05-08 06:56:22 UTC) #18
commit-bot: I haz the power
3 years, 7 months ago (2017-05-08 10:18:23 UTC) #21
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/07775ad85062bd6c858fbe553f0e...

Powered by Google App Engine
This is Rietveld 408576698