Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1137)

Unified Diff: third_party/WebKit/Source/core/editing/FrameSelection.cpp

Issue 2860593002: Prune ComputeVisibleSelectionInDOMTreeDeprecated from FrameSelection::SelectAll (Closed)
Patch Set: Fix unit test Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/editing/FrameSelection.cpp
diff --git a/third_party/WebKit/Source/core/editing/FrameSelection.cpp b/third_party/WebKit/Source/core/editing/FrameSelection.cpp
index 3ee3ee041c1788952e17959615677739200b0219..a72b84d0742eb0e106f7c4a3670f4cffb064404f 100644
--- a/third_party/WebKit/Source/core/editing/FrameSelection.cpp
+++ b/third_party/WebKit/Source/core/editing/FrameSelection.cpp
@@ -632,17 +632,16 @@ void FrameSelection::SelectAll() {
Node* root = nullptr;
Node* select_start_target = nullptr;
- if (ComputeVisibleSelectionInDOMTreeDeprecated().IsContentEditable()) {
- root = HighestEditableRoot(
- ComputeVisibleSelectionInDOMTreeDeprecated().Start());
+ if (ComputeVisibleSelectionInDOMTree().IsContentEditable()) {
+ root = HighestEditableRoot(ComputeVisibleSelectionInDOMTree().Start());
if (Node* shadow_root = NonBoundaryShadowTreeRootNode(
- ComputeVisibleSelectionInDOMTreeDeprecated().Start()))
+ ComputeVisibleSelectionInDOMTree().Start()))
select_start_target = shadow_root->OwnerShadowHost();
else
select_start_target = root;
} else {
root = NonBoundaryShadowTreeRootNode(
- ComputeVisibleSelectionInDOMTreeDeprecated().Start());
+ ComputeVisibleSelectionInDOMTree().Start());
if (root) {
select_start_target = root->OwnerShadowHost();
} else {
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698