third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp - Issue 2860593002: Prune ComputeVisibleSelectionInDOMTreeDeprecated from FrameSelection::SelectAll

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp

Issue 2860593002: Prune ComputeVisibleSelectionInDOMTreeDeprecated from FrameSelection::SelectAll (Closed)

Patch Set: Fix unit test Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp

diff --git a/third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp b/third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp

index 67b5b56b54dbad9f382ac7be1078763930e9ab19..31e6977cc0766080c32ff05d8c89463081e42df0 100644

--- a/third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp

+++ b/third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp

@@ -261,6 +261,7 @@ TEST_F(FrameSelectionTest, SelectAllWithInputElement) {

TEST_F(FrameSelectionTest, SelectAllWithUnselectableRoot) {

Element* select = GetDocument().createElement("select");

GetDocument().ReplaceChild(select, GetDocument().documentElement());

+ GetDocument().UpdateStyleAndLayout();

Selection().SelectAll();

EXPECT_TRUE(Selection().ComputeVisibleSelectionInDOMTreeDeprecated().IsNone())

<< "Nothing should be selected if the "

« no previous file with comments | « third_party/WebKit/Source/core/editing/FrameSelection.cpp ('k') | no next file » | no next file with comments »