Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2860023002: Eliminate lib directory for service manager client lib. (Closed)

Created:
3 years, 7 months ago by Ben Goodger (Google)
Modified:
3 years, 7 months ago
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Eliminate lib directory for service manager client lib. TBR=rockot@chromium.org Review-Url: https://codereview.chromium.org/2860023002 Cr-Commit-Position: refs/heads/master@{#469278} Committed: https://chromium.googlesource.com/chromium/src/+/677f1513be6a09f3dce0e1f96646cb2648c77b94

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -668 lines) Patch
M services/service_manager/public/cpp/BUILD.gn View 2 chunks +10 lines, -10 lines 0 comments Download
A + services/service_manager/public/cpp/bind_source_info.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + services/service_manager/public/cpp/binder_registry.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + services/service_manager/public/cpp/identity.cc View 1 chunk +3 lines, -4 lines 0 comments Download
A + services/service_manager/public/cpp/interface_provider.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + services/service_manager/public/cpp/interface_provider_spec.cc View 1 chunk +1 line, -1 line 0 comments Download
D services/service_manager/public/cpp/lib/bind_source_info.cc View 1 chunk +0 lines, -16 lines 0 comments Download
D services/service_manager/public/cpp/lib/binder_registry.cc View 1 chunk +0 lines, -57 lines 0 comments Download
D services/service_manager/public/cpp/lib/identity.cc View 1 chunk +0 lines, -50 lines 0 comments Download
D services/service_manager/public/cpp/lib/interface_provider.cc View 1 chunk +0 lines, -65 lines 0 comments Download
D services/service_manager/public/cpp/lib/interface_provider_spec.cc View 1 chunk +0 lines, -41 lines 0 comments Download
D services/service_manager/public/cpp/lib/service.cc View 1 chunk +0 lines, -59 lines 0 comments Download
D services/service_manager/public/cpp/lib/service_context.cc View 1 chunk +0 lines, -106 lines 0 comments Download
D services/service_manager/public/cpp/lib/service_context_ref.cc View 1 chunk +0 lines, -86 lines 0 comments Download
D services/service_manager/public/cpp/lib/service_runner.cc View 1 chunk +0 lines, -75 lines 0 comments Download
D services/service_manager/public/cpp/lib/service_test.cc View 1 chunk +0 lines, -96 lines 0 comments Download
A + services/service_manager/public/cpp/service.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + services/service_manager/public/cpp/service_context.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + services/service_manager/public/cpp/service_context_ref.cc View 3 chunks +3 lines, -6 lines 0 comments Download
A + services/service_manager/public/cpp/service_runner.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + services/service_manager/public/cpp/service_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Issue 2860943002 Patch 1

Dependent Patchsets:

Issue 2855393002 Patch 1

Messages

Total messages: 11 (8 generated)
Ben Goodger (Google)
3 years, 7 months ago (2017-05-04 05:34:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2860023002/1
3 years, 7 months ago (2017-05-04 05:40:43 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-05-04 05:44:50 UTC) #11
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/677f1513be6a09f3dce0e1f96646...

Powered by Google App Engine
This is Rietveld 408576698