Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 2860943002: Flatten interface_binder.h and callback_binder.h (Closed)

Created:
3 years, 7 months ago by Ben Goodger (Google)
Modified:
3 years, 7 months ago
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Flatten interface_binder.h and callback_binder.h TBR=rockot@chromium.org Review-Url: https://codereview.chromium.org/2860943002 Cr-Commit-Position: refs/heads/master@{#469277} Committed: https://chromium.googlesource.com/chromium/src/+/dc3b5830d0774b559d13435b3c28603d818afeb6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -132 lines) Patch
M services/service_manager/public/cpp/BUILD.gn View 1 chunk +1 line, -2 lines 0 comments Download
M services/service_manager/public/cpp/binder_registry.h View 2 chunks +4 lines, -4 lines 0 comments Download
M services/service_manager/public/cpp/interface_binder.h View 3 chunks +65 lines, -1 line 0 comments Download
A + services/service_manager/public/cpp/interface_binder.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M services/service_manager/public/cpp/lib/binder_registry.cc View 1 chunk +2 lines, -3 lines 0 comments Download
D services/service_manager/public/cpp/lib/callback_binder.h View 1 chunk +0 lines, -81 lines 0 comments Download
D services/service_manager/public/cpp/lib/callback_binder.cc View 1 chunk +0 lines, -37 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 10 (7 generated)
Ben Goodger (Google)
3 years, 7 months ago (2017-05-04 04:00:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2860943002/1
3 years, 7 months ago (2017-05-04 05:35:39 UTC) #7
commit-bot: I haz the power
3 years, 7 months ago (2017-05-04 05:40:04 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/dc3b5830d0774b559d13435b3c28...

Powered by Google App Engine
This is Rietveld 408576698