Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2855393002: Fix a TODO in GN file (Closed)

Created:
3 years, 7 months ago by Ben Goodger (Google)
Modified:
3 years, 7 months ago
CC:
chromium-reviews, rjkroege, ozone-reviews_chromium.org, sadrul, tfarina, dcheng, asvitkine+watch_chromium.org, kalyank
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -53 lines) Patch
M ash/autoclick/mus/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/touch_hud/mus/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M components/filesystem/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/leveldb/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/metrics/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mash/catalog_viewer/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M mash/example/views_examples/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mash/session/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M mash/task_viewer/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M services/device/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M services/service_manager/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M services/service_manager/background/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M services/service_manager/background/tests/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M services/service_manager/public/cpp/BUILD.gn View 1 chunk +2 lines, -9 lines 0 comments Download
M services/service_manager/runner/host/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M services/service_manager/tests/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M services/service_manager/tests/connect/BUILD.gn View 5 chunks +5 lines, -5 lines 0 comments Download
M services/service_manager/tests/lifecycle/BUILD.gn View 6 chunks +6 lines, -6 lines 0 comments Download
M services/service_manager/tests/service_manager/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M services/service_manager/tests/shutdown/BUILD.gn View 3 chunks +3 lines, -3 lines 0 comments Download
M services/ui/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M services/ui/clipboard/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M services/ui/demo/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M services/ui/ime/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M services/ui/ws/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/ozone/platform/drm/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/mus/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Issue 2860023002 Patch 1

Messages

Total messages: 10 (7 generated)
Ben Goodger (Google)
3 years, 7 months ago (2017-05-04 04:10:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2855393002/1
3 years, 7 months ago (2017-05-04 05:45:23 UTC) #7
commit-bot: I haz the power
3 years, 7 months ago (2017-05-04 05:49:44 UTC) #10
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/457a0ccf74d873f62036e0733a9e...

Powered by Google App Engine
This is Rietveld 408576698