Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Issue 2859583004: Revert of (Reland x2) Expose resources in Robolectric/JUnit tests. (Closed)

Created:
3 years, 7 months ago by aelias_OOO_until_Jul13
Modified:
3 years, 7 months ago
CC:
agrieve+watch_chromium.org, chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of (Reland x2) Expose resources in Robolectric/JUnit tests. (patchset #4 id:60001 of https://codereview.chromium.org/2842603002/ ) Reason for revert: TileGroupTest failing on waterfall, see http://crbug.com/717820 BUG=717820 Original issue's description: > (Reland x2) Expose resources in Robolectric/JUnit tests. > > Will let people use Android resources in Robolectric tests. > To use, specify package_name GN variable in junit_binary > targets with your apps package name. > > This change will also (basically) require that you use the > generated wrappers from out_dir/bin/run_<suite name> to run > the tests since GN will be generating many arguments to > pass along to the test runner. > > BUG=693573 > > Review-Url: https://codereview.chromium.org/2842603002 > Cr-Commit-Position: refs/heads/master@{#468822} > Committed: https://chromium.googlesource.com/chromium/src/+/bc26a6f5b4ed9ee2b84878c17e8f4149db815db7 TBR=agrieve@chromium.org,jbudorick@chromium.org,nyquist@chromium.org,mikecase@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=693573 Review-Url: https://codereview.chromium.org/2859583004 Cr-Commit-Position: refs/heads/master@{#468871} Committed: https://chromium.googlesource.com/chromium/src/+/a0f8ac5d596602275b1820e3f63d4966430f0de7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+125 lines, -249 lines) Patch
M build/android/gyp/create_test_runner_script.py View 3 chunks +0 lines, -16 lines 0 comments Download
M build/android/gyp/write_build_config.py View 2 chunks +1 line, -3 lines 0 comments Download
M build/android/lint/suppressions.xml View 5 chunks +28 lines, -28 lines 0 comments Download
M build/android/pylib/junit/junit_test_instance.py View 2 chunks +0 lines, -20 lines 0 comments Download
M build/android/pylib/local/machine/local_machine_junit_test_run.py View 4 chunks +16 lines, -47 lines 0 comments Download
M build/android/test_runner.py View 1 chunk +0 lines, -15 lines 0 comments Download
M build/android/test_runner.pydeps View 1 chunk +0 lines, -1 line 0 comments Download
M build/config/android/internal_rules.gni View 2 chunks +2 lines, -31 lines 0 comments Download
M build/config/android/rules.gni View 8 chunks +5 lines, -38 lines 0 comments Download
M chrome/android/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/suggestions/TileGroupTest.java View 5 chunks +56 lines, -1 line 0 comments Download
M testing/android/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M testing/android/junit/java/src/org/chromium/testing/local/GNManifestFactory.java View 1 chunk +11 lines, -40 lines 0 comments Download
M testing/android/junit/java/src/org/chromium/testing/local/LocalRobolectricTestRunner.java View 2 chunks +1 line, -5 lines 0 comments Download
M third_party/robolectric/README.chromium View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
aelias_OOO_until_Jul13
Created Revert of (Reland x2) Expose resources in Robolectric/JUnit tests.
3 years, 7 months ago (2017-05-03 02:00:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2859583004/1
3 years, 7 months ago (2017-05-03 02:01:21 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-05-03 02:03:20 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a0f8ac5d596602275b1820e3f63d...

Powered by Google App Engine
This is Rietveld 408576698