Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: build/android/lint/suppressions.xml

Issue 2859583004: Revert of (Reland x2) Expose resources in Robolectric/JUnit tests. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/android/gyp/write_build_config.py ('k') | build/android/pylib/junit/junit_test_instance.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <?xml version="1.0" encoding="utf-8"?> 1 <?xml version="1.0" encoding="utf-8"?>
2 <lint> 2 <lint>
3 <!-- 3 <!--
4 STOP! It looks like you want to suppress some lint errors: 4 STOP! It looks like you want to suppress some lint errors:
5 - Have you tried identifing the offending patch? 5 - Have you tried identifing the offending patch?
6 Ask the author for a fix and/or revert the patch. 6 Ask the author for a fix and/or revert the patch.
7 - It is preferred to add suppressions in the code instead of 7 - It is preferred to add suppressions in the code instead of
8 sweeping it under the rug here. See: 8 sweeping it under the rug here. See:
9 9
10 http://developer.android.com/tools/debugging/improving-w-lint.html 10 http://developer.android.com/tools/debugging/improving-w-lint.html
(...skipping 118 matching lines...) Expand 10 before | Expand all | Expand 10 after
129 </issue> 129 </issue>
130 <issue id="IconMissingDensityFolder"> 130 <issue id="IconMissingDensityFolder">
131 <!-- see crbug.com/542435 --> 131 <!-- see crbug.com/542435 -->
132 <ignore regexp="android_webview/apk/java/res"/> 132 <ignore regexp="android_webview/apk/java/res"/>
133 <ignore regexp="android_webview/tools/system_webview_shell/apk/res"/> 133 <ignore regexp="android_webview/tools/system_webview_shell/apk/res"/>
134 <ignore regexp="chrome/android/webapk/shell_apk/res"/> 134 <ignore regexp="chrome/android/webapk/shell_apk/res"/>
135 <ignore regexp="chromecast/internal"/> 135 <ignore regexp="chromecast/internal"/>
136 <ignore regexp="tools/android/push_apps_to_background/res"/> 136 <ignore regexp="tools/android/push_apps_to_background/res"/>
137 </issue> 137 </issue>
138 <issue id="ImpliedQuantity" severity="Error"> 138 <issue id="ImpliedQuantity" severity="Error">
139 <ignore regexp="chrome/android/chrome_strings_grd"/> 139 <ignore regexp="gen/chrome/android/chrome_strings_grd"/>
140 </issue> 140 </issue>
141 <issue id="InconsistentArrays" severity="Error"> 141 <issue id="InconsistentArrays" severity="Error">
142 <ignore regexp="android_webview/locale_paks.resources.zip/values/locale-paks .xml"/> 142 <ignore regexp="gen/android_webview/locale_paks.resources.zip/values/locale- paks.xml"/>
143 <ignore regexp="chrome/android/chrome_locale_paks.resources.zip/values/local e-paks.xml"/> 143 <ignore regexp="gen/chrome/android/chrome_locale_paks.resources.zip/values/l ocale-paks.xml"/>
144 </issue> 144 </issue>
145 <issue id="InconsistentLayout" severity="ignore"/> 145 <issue id="InconsistentLayout" severity="ignore"/>
146 <issue id="InefficientWeight" severity="Error"> 146 <issue id="InefficientWeight" severity="Error">
147 <ignore regexp="android_webview/tools/system_webview_shell/apk/res/layout/ac tivity_webview_browser.xml"/> 147 <ignore regexp="android_webview/tools/system_webview_shell/apk/res/layout/ac tivity_webview_browser.xml"/>
148 </issue> 148 </issue>
149 <issue id="InflateParams" severity="ignore"/> 149 <issue id="InflateParams" severity="ignore"/>
150 <issue id="InlinedApi" severity="ignore"/> 150 <issue id="InlinedApi" severity="ignore"/>
151 <issue id="InvalidPackage" severity="Error"> 151 <issue id="InvalidPackage" severity="Error">
152 <ignore regexp="espresso/espresso_core_java.interface.jar"/> 152 <ignore regexp="espresso/espresso_core_java.interface.jar"/>
153 </issue> 153 </issue>
(...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after
225 <ignore regexp="com/android/webview/chromium/ServiceWorkerSettingsAdapter.cl ass"/> 225 <ignore regexp="com/android/webview/chromium/ServiceWorkerSettingsAdapter.cl ass"/>
226 <!-- TODO(crbug.com/635567): Fix this properly. --> 226 <!-- TODO(crbug.com/635567): Fix this properly. -->
227 <ignore regexp="org/chromium/chrome/browser/ChromeActivity.class"/> 227 <ignore regexp="org/chromium/chrome/browser/ChromeActivity.class"/>
228 <!-- TODO(crbug.com/635567): Fix this properly. --> 228 <!-- TODO(crbug.com/635567): Fix this properly. -->
229 <ignore regexp="org/chromium/chrome/browser/ChromeTabbedActivity.class"/> 229 <ignore regexp="org/chromium/chrome/browser/ChromeTabbedActivity.class"/>
230 </issue> 230 </issue>
231 <issue id="PackageManagerGetSignatures"> 231 <issue id="PackageManagerGetSignatures">
232 <ignore regexp="chrome/android/webapk/libs/client/src/org/chromium/webapk/li b/client/WebApkValidator.java"/> 232 <ignore regexp="chrome/android/webapk/libs/client/src/org/chromium/webapk/li b/client/WebApkValidator.java"/>
233 </issue> 233 </issue>
234 <issue id="PluralsCandidate" severity="Error"> 234 <issue id="PluralsCandidate" severity="Error">
235 <ignore regexp="chrome/android/chrome_strings_grd.resources.zip/values-en-rG B/android_chrome_strings.xml"/> 235 <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-e n-rGB/android_chrome_strings.xml"/>
236 <ignore regexp="chrome/android/chrome_strings_grd.resources.zip/values/andro id_chrome_strings.xml"/> 236 <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values/a ndroid_chrome_strings.xml"/>
237 </issue> 237 </issue>
238 <issue id="Recycle" severity="ignore"/> 238 <issue id="Recycle" severity="ignore"/>
239 <issue id="Registered" severity="ignore"/> 239 <issue id="Registered" severity="ignore"/>
240 <issue id="RtlCompat" severity="ignore"/> 240 <issue id="RtlCompat" severity="ignore"/>
241 <issue id="RtlEnabled" severity="ignore"/> 241 <issue id="RtlEnabled" severity="ignore"/>
242 <issue id="RtlSymmetry" severity="ignore"/> 242 <issue id="RtlSymmetry" severity="ignore"/>
243 <issue id="SdCardPath"> 243 <issue id="SdCardPath">
244 <ignore regexp="content/public/android/java/src/org/chromium/content/browser /MediaResourceGetter.java"/> 244 <ignore regexp="content/public/android/java/src/org/chromium/content/browser /MediaResourceGetter.java"/>
245 </issue> 245 </issue>
246 <issue id="SetJavaScriptEnabled" severity="ignore"/> 246 <issue id="SetJavaScriptEnabled" severity="ignore"/>
247 <issue id="SignatureOrSystemPermissions" severity="ignore"/> 247 <issue id="SignatureOrSystemPermissions" severity="ignore"/>
248 <issue id="SpUsage" severity="Error"> 248 <issue id="SpUsage" severity="Error">
249 <ignore regexp="chromecast/internal"/> 249 <ignore regexp="chromecast/internal"/>
250 </issue> 250 </issue>
251 <issue id="StringFormatCount" severity="Error"> 251 <issue id="StringFormatCount" severity="Error">
252 <ignore regexp="chrome/android/chrome_strings_grd.resources.zip/values-cs/an droid_chrome_strings.xml"/> 252 <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-c s/android_chrome_strings.xml"/>
253 <ignore regexp="chrome/android/chrome_strings_grd.resources.zip/values-pl/an droid_chrome_strings.xml"/> 253 <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-p l/android_chrome_strings.xml"/>
254 <ignore regexp="chrome/android/chrome_strings_grd.resources.zip/values/andro id_chrome_strings.xml"/> 254 <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values/a ndroid_chrome_strings.xml"/>
255 </issue> 255 </issue>
256 <issue id="StringFormatInvalid" severity="Error"> 256 <issue id="StringFormatInvalid" severity="Error">
257 <ignore regexp="chrome/android/chrome_strings_grd.resources.zip/values-cs/an droid_chrome_strings.xml"/> 257 <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-c s/android_chrome_strings.xml"/>
258 <ignore regexp="chrome/android/chrome_strings_grd.resources.zip/values-da/an droid_chrome_strings.xml"/> 258 <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-d a/android_chrome_strings.xml"/>
259 <ignore regexp="chrome/android/chrome_strings_grd.resources.zip/values-pl/an droid_chrome_strings.xml"/> 259 <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-p l/android_chrome_strings.xml"/>
260 <ignore regexp="chrome/android/chrome_strings_grd.resources.zip/values-pt-rB R/android_chrome_strings.xml"/> 260 <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-p t-rBR/android_chrome_strings.xml"/>
261 <ignore regexp="chrome/android/chrome_strings_grd.resources.zip/values-sv/an droid_chrome_strings.xml"/> 261 <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-s v/android_chrome_strings.xml"/>
262 <ignore regexp="chrome/android/chrome_strings_grd.resources.zip/values-tl/an droid_chrome_strings.xml"/> 262 <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-t l/android_chrome_strings.xml"/>
263 </issue> 263 </issue>
264 <issue id="TextFields" severity="Error"> 264 <issue id="TextFields" severity="Error">
265 <ignore regexp="chromecast/internal"/> 265 <ignore regexp="chromecast/internal"/>
266 </issue> 266 </issue>
267 <issue id="TypographyDashes" severity="Error"> 267 <issue id="TypographyDashes" severity="Error">
268 <ignore regexp="chrome/app/policy/android/values-v21/restriction_values.xml" /> 268 <ignore regexp="chrome/app/policy/android/values-v21/restriction_values.xml" />
269 </issue> 269 </issue>
270 <!-- Typos check disabled due to lint bug: http://crbug.com/671170 --> 270 <!-- Typos check disabled due to lint bug: http://crbug.com/671170 -->
271 <issue id="Typos" severity="ignore" /> 271 <issue id="Typos" severity="ignore" />
272 <issue id="UnusedAttribute" severity="ignore"/> 272 <issue id="UnusedAttribute" severity="ignore"/>
273 <issue id="UnusedIds" severity="ignore"/> 273 <issue id="UnusedIds" severity="ignore"/>
274 <issue id="UnusedQuantity" severity="Error"> 274 <issue id="UnusedQuantity" severity="Error">
275 <ignore regexp="chrome/android/chrome_strings_grd.resources.zip/values-cs/an droid_chrome_strings.xml"/> 275 <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-c s/android_chrome_strings.xml"/>
276 <ignore regexp="chrome/android/chrome_strings_grd.resources.zip/values-in/an droid_chrome_strings.xml"/> 276 <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-i n/android_chrome_strings.xml"/>
277 <ignore regexp="chrome/android/chrome_strings_grd.resources.zip/values-ja/an droid_chrome_strings.xml"/> 277 <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-j a/android_chrome_strings.xml"/>
278 <ignore regexp="chrome/android/chrome_strings_grd.resources.zip/values-ko/an droid_chrome_strings.xml"/> 278 <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-k o/android_chrome_strings.xml"/>
279 <ignore regexp="chrome/android/chrome_strings_grd.resources.zip/values-lt/an droid_chrome_strings.xml"/> 279 <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-l t/android_chrome_strings.xml"/>
280 <ignore regexp="chrome/android/chrome_strings_grd.resources.zip/values-sk/an droid_chrome_strings.xml"/> 280 <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-s k/android_chrome_strings.xml"/>
281 <ignore regexp="chrome/android/chrome_strings_grd.resources.zip/values-th/an droid_chrome_strings.xml"/> 281 <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-t h/android_chrome_strings.xml"/>
282 <ignore regexp="chrome/android/chrome_strings_grd.resources.zip/values-vi/an droid_chrome_strings.xml"/> 282 <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-v i/android_chrome_strings.xml"/>
283 <ignore regexp="chrome/android/chrome_strings_grd.resources.zip/values-zh-rC N/android_chrome_strings.xml"/> 283 <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-z h-rCN/android_chrome_strings.xml"/>
284 <ignore regexp="chrome/android/chrome_strings_grd.resources.zip/values-zh-rT W/android_chrome_strings.xml"/> 284 <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-z h-rTW/android_chrome_strings.xml"/>
285 </issue> 285 </issue>
286 <!-- TODO(crbug.com/635567): Fix this properly. --> 286 <!-- TODO(crbug.com/635567): Fix this properly. -->
287 <issue id="UnusedResources" severity="ignore"/> 287 <issue id="UnusedResources" severity="ignore"/>
288 <issue id="UnusedResources"> 288 <issue id="UnusedResources">
289 <ignore regexp="PRODUCT_DIR/gen/remoting/android/remoting_android_raw_resour ces/res/raw/credits.html"/> 289 <ignore regexp="PRODUCT_DIR/gen/remoting/android/remoting_android_raw_resour ces/res/raw/credits.html"/>
290 <ignore regexp="PRODUCT_DIR/gen/remoting/android/remoting_android_raw_resour ces/res/raw/credits_css.css"/> 290 <ignore regexp="PRODUCT_DIR/gen/remoting/android/remoting_android_raw_resour ces/res/raw/credits_css.css"/>
291 <ignore regexp="PRODUCT_DIR/gen/remoting/android/remoting_android_raw_resour ces/res/raw/credits_js.js"/> 291 <ignore regexp="PRODUCT_DIR/gen/remoting/android/remoting_android_raw_resour ces/res/raw/credits_js.js"/>
292 <ignore regexp="PRODUCT_DIR/gen/remoting/android/remoting_android_raw_resour ces/res/raw/main.css"/> 292 <ignore regexp="PRODUCT_DIR/gen/remoting/android/remoting_android_raw_resour ces/res/raw/main.css"/>
293 <ignore regexp="android_ui_strings.xml"/> 293 <ignore regexp="android_ui_strings.xml"/>
294 <ignore regexp="android_webview/java/res/drawable-hdpi/ic_play_circle_outlin e_black_48dp.png"/> 294 <ignore regexp="android_webview/java/res/drawable-hdpi/ic_play_circle_outlin e_black_48dp.png"/>
(...skipping 29 matching lines...) Expand all
324 <ignore regexp="chrome/android/java/res/drawable-hdpi/progress_bar_backgroun d_white.9.png"/> 324 <ignore regexp="chrome/android/java/res/drawable-hdpi/progress_bar_backgroun d_white.9.png"/>
325 <ignore regexp="chrome/android/java/res/drawable-hdpi/shortcut_incognito.png "/> 325 <ignore regexp="chrome/android/java/res/drawable-hdpi/shortcut_incognito.png "/>
326 <ignore regexp="chrome/android/java/res/drawable-hdpi/shortcut_newtab.png"/> 326 <ignore regexp="chrome/android/java/res/drawable-hdpi/shortcut_newtab.png"/>
327 <ignore regexp="chrome/android/java/res/drawable-hdpi/signin_promo_illustrat ion.png"/> 327 <ignore regexp="chrome/android/java/res/drawable-hdpi/signin_promo_illustrat ion.png"/>
328 <ignore regexp="chrome/android/java/res/drawable-nodpi/missing.png"/> 328 <ignore regexp="chrome/android/java/res/drawable-nodpi/missing.png"/>
329 <ignore regexp="chrome/android/java/res/values-v17/styles.xml"/> 329 <ignore regexp="chrome/android/java/res/values-v17/styles.xml"/>
330 <ignore regexp="chromecast/browser/android/apk/res/values/strings.xml"/> 330 <ignore regexp="chromecast/browser/android/apk/res/values/strings.xml"/>
331 <ignore regexp="chromecast/internal"/> 331 <ignore regexp="chromecast/internal"/>
332 <ignore regexp="clank"/> 332 <ignore regexp="clank"/>
333 <ignore regexp="content/shell/android/java/res/mipmap-hdpi/app_icon.png"/> 333 <ignore regexp="content/shell/android/java/res/mipmap-hdpi/app_icon.png"/>
334 <ignore regexp="android_webview/locale_paks.resources.zip/*"/> 334 <ignore regexp="gen/android_webview/locale_paks.resources.zip/*"/>
335 <ignore regexp="android_webview/strings_grd.resources.zip/values/android_web view_strings.xml"/> 335 <ignore regexp="gen/android_webview/strings_grd.resources.zip/values/android _webview_strings.xml"/>
336 <ignore regexp="components/strings/components_strings_grd.resources.zip/valu es.*/components_strings.xml"/> 336 <ignore regexp="gen/components/strings/components_strings_grd.resources.zip/ values.*/components_strings.xml"/>
337 <ignore regexp="remoting/resources/strings_java.resources.zip/values/remotin g_strings.xml"/> 337 <ignore regexp="gen/remoting/resources/strings_java.resources.zip/values/rem oting_strings.xml"/>
338 <ignore regexp="remoting/android/java/res/drawable-hdpi/ic_backspace.png"/> 338 <ignore regexp="remoting/android/java/res/drawable-hdpi/ic_backspace.png"/>
339 <ignore regexp="remoting/android/java/res/drawable-hdpi/ic_cardboard.png"/> 339 <ignore regexp="remoting/android/java/res/drawable-hdpi/ic_cardboard.png"/>
340 <ignore regexp="remoting/android/java/res/drawable-hdpi/ic_voice_input.png"/ > 340 <ignore regexp="remoting/android/java/res/drawable-hdpi/ic_voice_input.png"/ >
341 <ignore regexp="remoting/android/java/res/drawable-hdpi/ic_zoom_in.png"/> 341 <ignore regexp="remoting/android/java/res/drawable-hdpi/ic_zoom_in.png"/>
342 <ignore regexp="remoting/android/java/res/drawable-hdpi/ic_zoom_out.png"/> 342 <ignore regexp="remoting/android/java/res/drawable-hdpi/ic_zoom_out.png"/>
343 <ignore regexp="remoting/android/java/res/layout/navigation_list_item.xml"/> 343 <ignore regexp="remoting/android/java/res/layout/navigation_list_item.xml"/>
344 <ignore regexp="remoting/android/java/res/mipmap-hdpi/logo_remote_desktop_la uncher.png"/> 344 <ignore regexp="remoting/android/java/res/mipmap-hdpi/logo_remote_desktop_la uncher.png"/>
345 <ignore regexp="remoting/android/java/res/values-v17/styles.xml"/> 345 <ignore regexp="remoting/android/java/res/values-v17/styles.xml"/>
346 <!-- Used by Android's policies system --> 346 <!-- Used by Android's policies system -->
347 <ignore regexp="restriction_values.xml"/> 347 <ignore regexp="restriction_values.xml"/>
(...skipping 98 matching lines...) Expand 10 before | Expand all | Expand 10 after
446 <ignore regexp="media/capture/content/android/java/src/org/chromium/media/Sc reenCapture.java"/> 446 <ignore regexp="media/capture/content/android/java/src/org/chromium/media/Sc reenCapture.java"/>
447 </issue> 447 </issue>
448 <issue id="ViewConstructor" severity="ignore"/> 448 <issue id="ViewConstructor" severity="ignore"/>
449 <issue id="WrongCall" severity="ignore"/> 449 <issue id="WrongCall" severity="ignore"/>
450 <issue id="WrongConstant"> 450 <issue id="WrongConstant">
451 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/SSLClien tCertificateRequest.java"/> 451 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/SSLClien tCertificateRequest.java"/>
452 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/payments /ui/EditorView.java"/> 452 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/payments /ui/EditorView.java"/>
453 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/signin/S igninAndSyncView.java"/> 453 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/signin/S igninAndSyncView.java"/>
454 </issue> 454 </issue>
455 </lint> 455 </lint>
OLDNEW
« no previous file with comments | « build/android/gyp/write_build_config.py ('k') | build/android/pylib/junit/junit_test_instance.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698