Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 2859053003: [EasyUnlock] Add beacon_seeds to RemoteDevice. (Closed)

Created:
3 years, 7 months ago by Tim Song
Modified:
3 years, 7 months ago
CC:
chromium-reviews, jlklein+watch-tether_chromium.org, tengs+watch-tether_chromium.org, hansberry+watch-tether_chromium.org, jhawkins+watch-tether_chromium.org, lesliewatkins+watch-tether_chromium.org, khorimoto+watch-tether_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[EasyUnlock] Add beacon_seeds to RemoteDevice. Because BeaconSeeds can take quite a bit of space, we also add an option in RemoteDeviceLoader whether or not to load the BeaconSeeds. Review-Url: https://codereview.chromium.org/2859053003 Cr-Original-Commit-Position: refs/heads/master@{#473489} Committed: https://chromium.googlesource.com/chromium/src/+/c3636c2887c896911de99d208889b2582cf5e56b Review-Url: https://codereview.chromium.org/2859053003 Cr-Commit-Position: refs/heads/master@{#473698} Committed: https://chromium.googlesource.com/chromium/src/+/b4388f67d576b77e139f834695c461e625560779

Patch Set 1 : [EasyUnlock] Add beacon_seeds to RemoteDevice. #

Total comments: 11

Patch Set 2 : fixes #

Total comments: 4

Patch Set 3 : fixes #

Patch Set 4 : load beacon seed in RemoteDevice #

Total comments: 10

Patch Set 5 : refactor comparison logic #

Patch Set 6 : fix compile #

Patch Set 7 : fix memory issue #

Unified diffs Side-by-side diffs Delta from patch set Stats (+170 lines, -56 lines) Patch
M chrome/browser/signin/easy_unlock_app_manager.cc View 1 2 3 4 5 2 chunks +7 lines, -1 line 0 comments Download
M chrome/browser/signin/easy_unlock_service_regular.cc View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M chromeos/components/tether/tether_host_fetcher.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chromeos/components/tether/tether_host_fetcher_unittest.cc View 1 2 3 4 5 2 chunks +4 lines, -3 lines 0 comments Download
M components/cryptauth/remote_device.h View 1 2 3 3 chunks +10 lines, -0 lines 0 comments Download
M components/cryptauth/remote_device.cc View 1 2 3 4 5 6 3 chunks +47 lines, -7 lines 0 comments Download
M components/cryptauth/remote_device_loader.h View 1 2 2 chunks +7 lines, -1 line 0 comments Download
M components/cryptauth/remote_device_loader.cc View 1 2 3 3 chunks +16 lines, -4 lines 0 comments Download
M components/cryptauth/remote_device_loader_unittest.cc View 1 2 3 4 8 chunks +73 lines, -7 lines 0 comments Download
M components/proximity_auth/bluetooth_low_energy_connection_finder.h View 3 chunks +0 lines, -6 lines 0 comments Download
M components/proximity_auth/bluetooth_low_energy_connection_finder.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M components/proximity_auth/bluetooth_low_energy_connection_finder_unittest.cc View 2 chunks +0 lines, -11 lines 0 comments Download
M components/proximity_auth/bluetooth_low_energy_setup_connection_finder.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/proximity_auth/remote_device_life_cycle_impl.cc View 1 chunk +1 line, -10 lines 0 comments Download
M components/proximity_auth/webui/proximity_auth_webui_handler.cc View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 38 (15 generated)
Tim Song
Hey Kyle, I know we had some discussions about including the BeaconSeeds in the RemoteDevice ...
3 years, 7 months ago (2017-05-04 02:55:18 UTC) #3
Kyle Horimoto
https://codereview.chromium.org/2859053003/diff/20001/components/cryptauth/remote_device.cc File components/cryptauth/remote_device.cc (right): https://codereview.chromium.org/2859053003/diff/20001/components/cryptauth/remote_device.cc#newcode41 components/cryptauth/remote_device.cc:41: // Note: We don't compare the |beacon_seeds| for equality ...
3 years, 7 months ago (2017-05-04 03:52:52 UTC) #4
Tim Song
Hey Ryan, both Gustavo and Kyle are OOO. Can you take a look at this ...
3 years, 7 months ago (2017-05-06 22:53:17 UTC) #6
Ryan Hansberry
https://codereview.chromium.org/2859053003/diff/20001/components/cryptauth/remote_device.h File components/cryptauth/remote_device.h (right): https://codereview.chromium.org/2859053003/diff/20001/components/cryptauth/remote_device.h#newcode15 components/cryptauth/remote_device.h:15: struct RemoteDevice { On 2017/05/06 22:53:16, Tim Song wrote: ...
3 years, 7 months ago (2017-05-09 02:32:19 UTC) #7
Tim Song
https://codereview.chromium.org/2859053003/diff/20001/components/cryptauth/remote_device.h File components/cryptauth/remote_device.h (right): https://codereview.chromium.org/2859053003/diff/20001/components/cryptauth/remote_device.h#newcode15 components/cryptauth/remote_device.h:15: struct RemoteDevice { On 2017/05/09 02:32:19, Ryan Hansberry wrote: ...
3 years, 7 months ago (2017-05-10 21:58:08 UTC) #8
sacomoto
On 2017/05/10 21:58:08, Tim Song wrote: > https://codereview.chromium.org/2859053003/diff/20001/components/cryptauth/remote_device.h > File components/cryptauth/remote_device.h (right): > > https://codereview.chromium.org/2859053003/diff/20001/components/cryptauth/remote_device.h#newcode15 ...
3 years, 7 months ago (2017-05-15 14:02:20 UTC) #9
Ryan Hansberry
https://codereview.chromium.org/2859053003/diff/20001/components/cryptauth/remote_device.h File components/cryptauth/remote_device.h (right): https://codereview.chromium.org/2859053003/diff/20001/components/cryptauth/remote_device.h#newcode15 components/cryptauth/remote_device.h:15: struct RemoteDevice { On 2017/05/10 21:58:08, Tim Song wrote: ...
3 years, 7 months ago (2017-05-15 15:43:34 UTC) #10
Tim Song
Okay, I changed RemoteDevice to include an are_beacon_seeds_loaded field and perform a comparison if it ...
3 years, 7 months ago (2017-05-17 23:48:22 UTC) #11
Tim Song
Okay, I changed RemoteDevice to include an are_beacon_seeds_loaded field and perform a comparison if it ...
3 years, 7 months ago (2017-05-17 23:48:23 UTC) #12
Jeremy Klein
Just a word of warning here: the beaconseeds are really memory heavy. In fact, we ...
3 years, 7 months ago (2017-05-17 23:53:30 UTC) #14
Tim Song
Yeah, this is the source of the back and forth on this CL. I think ...
3 years, 7 months ago (2017-05-18 00:56:08 UTC) #15
Ryan Hansberry
https://codereview.chromium.org/2859053003/diff/80001/components/cryptauth/remote_device.cc File components/cryptauth/remote_device.cc (right): https://codereview.chromium.org/2859053003/diff/80001/components/cryptauth/remote_device.cc#newcode32 components/cryptauth/remote_device.cc:32: this->are_beacon_seeds_loaded = true; nit: remove 'this' https://codereview.chromium.org/2859053003/diff/80001/components/cryptauth/remote_device.cc#newcode33 components/cryptauth/remote_device.cc:33: this->beacon_seeds ...
3 years, 7 months ago (2017-05-19 18:28:44 UTC) #16
Tim Song
https://codereview.chromium.org/2859053003/diff/80001/components/cryptauth/remote_device.cc File components/cryptauth/remote_device.cc (right): https://codereview.chromium.org/2859053003/diff/80001/components/cryptauth/remote_device.cc#newcode32 components/cryptauth/remote_device.cc:32: this->are_beacon_seeds_loaded = true; On 2017/05/19 18:28:43, Ryan Hansberry wrote: ...
3 years, 7 months ago (2017-05-19 21:19:34 UTC) #17
Ryan Hansberry
lgtm
3 years, 7 months ago (2017-05-19 21:31:06 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2859053003/100001
3 years, 7 months ago (2017-05-19 22:44:20 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/430980)
3 years, 7 months ago (2017-05-19 23:12:00 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2859053003/120001
3 years, 7 months ago (2017-05-21 22:58:33 UTC) #25
commit-bot: I haz the power
Committed patchset #6 (id:120001) as https://chromium.googlesource.com/chromium/src/+/c3636c2887c896911de99d208889b2582cf5e56b
3 years, 7 months ago (2017-05-22 00:24:18 UTC) #28
findit-for-me
Findit (https://goo.gl/kROfz5) identified this CL at revision 473489 as the culprit for failures in the ...
3 years, 7 months ago (2017-05-22 01:55:00 UTC) #29
tsergeant
A revert of this CL (patchset #6 id:120001) has been created in https://codereview.chromium.org/2897843002/ by tsergeant@chromium.org. ...
3 years, 7 months ago (2017-05-22 04:34:04 UTC) #30
Tim Song
Fixed use-of-uninitialized-value error. Relanding.
3 years, 7 months ago (2017-05-22 19:44:02 UTC) #34
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2859053003/140001
3 years, 7 months ago (2017-05-22 19:44:24 UTC) #35
commit-bot: I haz the power
3 years, 7 months ago (2017-05-22 21:17:22 UTC) #38
Message was sent while issue was closed.
Committed patchset #7 (id:140001) as
https://chromium.googlesource.com/chromium/src/+/b4388f67d576b77e139f834695c4...

Powered by Google App Engine
This is Rietveld 408576698