[EasyUnlock] Add beacon_seeds to RemoteDevice.

components/cryptauth/remote_device_loader.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_CRYPTAUTH_REMOTE_DEVICE_LOADER_H_
 #define COMPONENTS_CRYPTAUTH_REMOTE_DEVICE_LOADER_H_
 
 #include <memory>
 #include <string>
 
@@ skipping 46 matching lines @@
       const std::string& user_id,
       const std::string& user_private_key,
       std::unique_ptr<cryptauth::SecureMessageDelegate>
           secure_message_delegate);
 
   virtual ~RemoteDeviceLoader();
 
   // Loads the RemoteDevice objects. |callback| will be invoked upon completion.
   typedef base::Callback<void(const cryptauth::RemoteDeviceList&)>
       RemoteDeviceCallback;
   virtual void Load(const RemoteDeviceCallback& callback);

[Kyle Horimoto, 2017/05/04 03:52:51]

Can you pass |should_load_beacon_seeds| as a parameter here instead? I think
each client should explicitly state whether it wants beacon seeds. I feel like
the function you wrote could be easily missed by someone casually looking at
this file.

[Tim Song, 2017/05/06 22:53:16]

Done.

 
+  void set_should_load_beacon_seeds(bool should_load_beacon_seeds) {
+    should_load_beacon_seeds_ = should_load_beacon_seeds;
+  }
+
  private:
   // Called when the PSK is derived for each device. If the PSKs for all devices
   // have been derived, then we can invoke |callback_|.
   void OnPSKDerived(const cryptauth::ExternalDeviceInfo& device,
                     const std::string& psk);
 
+  // True if the loader should include BeaconSeeds in the loaded RemoteDevices.
+  bool should_load_beacon_seeds_;
+
   // The remaining devices whose PSK we're waiting on.
   std::vector<cryptauth::ExternalDeviceInfo> remaining_devices_;
 
   // The id of the user who the remote devices belong to.
   const std::string user_id_;
 
   // The private key of the user's local device.
   const std::string user_private_key_;
 
   // Performs the PSK key derivation.
   std::unique_ptr<cryptauth::SecureMessageDelegate> secure_message_delegate_;
 
   // Invoked when the RemoteDevices are loaded.
   RemoteDeviceCallback callback_;
 
   // The collection of RemoteDevices to return.
   cryptauth::RemoteDeviceList remote_devices_;
 
   base::WeakPtrFactory<RemoteDeviceLoader> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(RemoteDeviceLoader);
 };
 
 }  // namespace cryptauth
 
 #endif  // COMPONENTS_CRYPTAUTH_REMOTE_DEVICE_LOADER_H_