[EasyUnlock] Add beacon_seeds to RemoteDevice.

components/cryptauth/remote_device.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/cryptauth/remote_device.h"
 
 #include "base/base64.h"
 
 namespace cryptauth {
 
@@ skipping 20 matching lines @@
   std::string to_return;
   base::Base64Encode(public_key, &to_return);
   return to_return;
 }
 
 std::string RemoteDevice::GetTruncatedDeviceIdForLogs() const {
   return RemoteDevice::TruncateDeviceIdForLogs(GetDeviceId());
 }
 
 bool RemoteDevice::operator==(const RemoteDevice& other) const {
+  // Note: We don't compare the |beacon_seeds| for equality as they may not be

[Kyle Horimoto, 2017/05/04 03:52:51]

If the "hast fetched" values are equal, also compare the seeds.

[Tim Song, 2017/05/06 22:53:16]

As mentioned in the header file, there are some issues with keeping a
has_fetched_beacon_seeds field. In addition there are some other reasons why
comparing the BeaconSeed is problematic:
1. Comparing protos is non-trivial
2. In theory, we should only need to compare the public_key for equality. Any
differing fields should be an undefined state.

+  // present.
   return user_id == other.user_id
       && name == other.name
       && public_key == other.public_key
       && bluetooth_address == other.bluetooth_address
       && persistent_symmetric_key == other.persistent_symmetric_key
       && sign_in_challenge == other.sign_in_challenge;
 }
 
 bool RemoteDevice::operator<(const RemoteDevice& other) const {
   // |public_key| is the only field guaranteed to be set and is also unique to
   // each RemoteDevice. However, since it can contain null bytes, use
   // GetDeviceId(), which cannot contain null bytes, to compare devices.
   return GetDeviceId().compare(other.GetDeviceId()) < 0;
 }
 
 // static
 std::string RemoteDevice::TruncateDeviceIdForLogs(const std::string& full_id) {
   if (full_id.length() <= 10) {
     return full_id;
   }
 
   return full_id.substr(0, 5)
       + "..."
       + full_id.substr(full_id.length() - 5, full_id.length());
 }
 
 }  // namespace cryptauth