Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issue 2858773002: Revert of PaymentHandler: Implement PaymentInstruments.keys(). (Closed)

Created:
3 years, 7 months ago by adithyas
Modified:
3 years, 7 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, kinuko+watch, jsbell+serviceworker_chromium.org, tzik, jam, abarth-chromium, darin-cc_chromium.org, blink-reviews, gogerald+paymentswatch_chromium.org, blink-worker-reviews_chromium.org, nhiroki, rouslan+payments_chromium.org, haraken, michaeln, shimazu+serviceworker_chromium.org, serviceworker-reviews, Aaron Boodman, kinuko+serviceworker, mahmadi+paymentswatch_chromium.org, horo+watch_chromium.org, darin (slow to review), sebsg+paymentswatch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of PaymentHandler: Implement PaymentInstruments.keys(). (patchset #3 id:40001 of https://codereview.chromium.org/2850203002/ ) Reason for revert: This patch is causing some PaymentManager tests to fail. Original issue's description: > PaymentHandler: Implement PaymentInstruments.keys(). > > The method to return keys of the stored payment instruments in insertion order. > > Related Spec Link: > https://w3c.github.io/webpayments-payment-handler/#paymentinstruments-interface > > BUG=661608 > TEST=payment_manager_unittest.cc, payment-instruments.html > > Review-Url: https://codereview.chromium.org/2850203002 > Cr-Commit-Position: refs/heads/master@{#468747} > Committed: https://chromium.googlesource.com/chromium/src/+/09c61ecc5adf140aa7a59aef0ecacc510e0be1d8 TBR=rouslan@chromium.org,tsepez@chromium.org,nhiroki@chromium.org,jinho.bang@samsung.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=661608 Review-Url: https://codereview.chromium.org/2858773002 Cr-Commit-Position: refs/heads/master@{#468773} Committed: https://chromium.googlesource.com/chromium/src/+/9d3c221bdef03b02ef3ed0fe150433592d960f19

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -393 lines) Patch
M components/payments/mojom/payment_app.mojom View 1 chunk +4 lines, -6 lines 0 comments Download
M content/browser/payments/payment_app.proto View 1 chunk +0 lines, -5 lines 0 comments Download
M content/browser/payments/payment_app_database.h View 3 chunks +0 lines, -14 lines 0 comments Download
M content/browser/payments/payment_app_database.cc View 7 chunks +7 lines, -88 lines 0 comments Download
M content/browser/payments/payment_manager.h View 1 chunk +6 lines, -8 lines 0 comments Download
M content/browser/payments/payment_manager.cc View 2 chunks +18 lines, -26 lines 0 comments Download
M content/browser/payments/payment_manager_unittest.cc View 3 chunks +0 lines, -47 lines 0 comments Download
M content/browser/service_worker/service_worker_context_wrapper.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/service_worker/service_worker_context_wrapper.cc View 1 chunk +0 lines, -14 lines 0 comments Download
M content/browser/service_worker/service_worker_database.h View 1 chunk +0 lines, -7 lines 0 comments Download
M content/browser/service_worker/service_worker_database.cc View 1 chunk +0 lines, -44 lines 0 comments Download
M content/browser/service_worker/service_worker_storage.h View 2 chunks +2 lines, -12 lines 0 comments Download
M content/browser/service_worker/service_worker_storage.cc View 2 chunks +0 lines, -48 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/payments/payment-instruments.html View 1 chunk +0 lines, -42 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentInstruments.h View 2 chunks +1 line, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentInstruments.cpp View 2 chunks +3 lines, -24 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentInstruments.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
adithyas
Created Revert of PaymentHandler: Implement PaymentInstruments.keys().
3 years, 7 months ago (2017-05-02 21:19:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2858773002/1
3 years, 7 months ago (2017-05-02 21:20:04 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-05-02 21:21:45 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9d3c221bdef03b02ef3ed0fe1504...

Powered by Google App Engine
This is Rietveld 408576698