Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10848)

Unified Diff: content/browser/payments/payment_manager_unittest.cc

Issue 2858773002: Revert of PaymentHandler: Implement PaymentInstruments.keys(). (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/payments/payment_manager_unittest.cc
diff --git a/content/browser/payments/payment_manager_unittest.cc b/content/browser/payments/payment_manager_unittest.cc
index 195d3527be5648e00e3a2d9db0b2f9543b7f324e..37d48295ad534b9e7b64ce88f9cc2daf03686883 100644
--- a/content/browser/payments/payment_manager_unittest.cc
+++ b/content/browser/payments/payment_manager_unittest.cc
@@ -50,14 +50,6 @@
*out_status = status;
}
-void KeysOfPaymentInstrumentsCallback(std::vector<std::string>* out_keys,
- PaymentHandlerStatus* out_status,
- const std::vector<std::string>& keys,
- PaymentHandlerStatus status) {
- *out_keys = keys;
- *out_status = status;
-}
-
void HasPaymentInstrumentCallback(PaymentHandlerStatus* out_status,
PaymentHandlerStatus status) {
*out_status = status;
@@ -97,13 +89,6 @@
manager_->SetPaymentInstrument(
instrument_key, std::move(instrument),
base::Bind(&SetPaymentInstrumentCallback, out_status));
- base::RunLoop().RunUntilIdle();
- }
-
- void KeysOfPaymentInstruments(std::vector<std::string>* out_keys,
- PaymentHandlerStatus* out_status) {
- manager_->KeysOfPaymentInstruments(
- base::Bind(&KeysOfPaymentInstrumentsCallback, out_keys, out_status));
base::RunLoop().RunUntilIdle();
}
@@ -262,36 +247,4 @@
ASSERT_EQ(PaymentHandlerStatus::NOT_FOUND, has_status);
}
-TEST_F(PaymentManagerTest, KeysOfPaymentInstruments) {
- PaymentHandlerStatus keys_status = PaymentHandlerStatus::NOT_FOUND;
- std::vector<std::string> keys;
- KeysOfPaymentInstruments(&keys, &keys_status);
- ASSERT_EQ(PaymentHandlerStatus::SUCCESS, keys_status);
- ASSERT_EQ(0U, keys.size());
-
- {
- PaymentHandlerStatus write_status = PaymentHandlerStatus::NOT_FOUND;
- SetPaymentInstrument("test_key1", PaymentInstrument::New(), &write_status);
- ASSERT_EQ(PaymentHandlerStatus::SUCCESS, write_status);
- }
- {
- PaymentHandlerStatus write_status = PaymentHandlerStatus::NOT_FOUND;
- SetPaymentInstrument("test_key3", PaymentInstrument::New(), &write_status);
- ASSERT_EQ(PaymentHandlerStatus::SUCCESS, write_status);
- }
- {
- PaymentHandlerStatus write_status = PaymentHandlerStatus::NOT_FOUND;
- SetPaymentInstrument("test_key2", PaymentInstrument::New(), &write_status);
- ASSERT_EQ(PaymentHandlerStatus::SUCCESS, write_status);
- }
-
- keys_status = PaymentHandlerStatus::NOT_FOUND;
- KeysOfPaymentInstruments(&keys, &keys_status);
- ASSERT_EQ(PaymentHandlerStatus::SUCCESS, keys_status);
- ASSERT_EQ(3U, keys.size());
- ASSERT_EQ("test_key1", keys[0]);
- ASSERT_EQ("test_key3", keys[1]);
- ASSERT_EQ("test_key2", keys[2]);
-}
-
} // namespace content
« no previous file with comments | « content/browser/payments/payment_manager.cc ('k') | content/browser/service_worker/service_worker_context_wrapper.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698