PaymentHandler: Implement PaymentInstruments.keys().

PaymentHandler: Implement PaymentInstruments.keys().

The method to return keys of the stored payment instruments in insertion order.

Related Spec Link:
  https://w3c.github.io/webpayments-payment-handler/#paymentinstruments-interface

BUG=661608
TEST=payment_manager_unittest.cc, payment-instruments.html

Review-Url: https://codereview.chromium.org/2850203002
Cr-Commit-Position: refs/heads/master@{#468747}
Committed: https://chromium.googlesource.com/chromium/src/+/09c61ecc5adf140aa7a59aef0ecacc510e0be1d8

[zino, 2017-05-01 17:37:50]

Description was changed from

==========
PaymentHandler: Implement PaymentInstruments.Keys().

The method to return keys of the stored payment instruments in insertion order.

Related Spec Link:
 
https://w3c.github.io/webpayments-payment-handler/#paymentinstruments-interface

BUG=661608
==========

to

==========
PaymentHandler: Implement PaymentInstruments.keys().

The method to return keys of the stored payment instruments in insertion order.

Related Spec Link:
 
https://w3c.github.io/webpayments-payment-handler/#paymentinstruments-interface

BUG=661608
==========

[zino, 2017-05-01 17:39:02]

jinho.bang@samsung.com changed reviewers:
+ nhiroki@chromium.org, rouslan@chromium.org, tsepez@chromium.org

[zino, 2017-05-01 17:39:38]

Description was changed from

==========
PaymentHandler: Implement PaymentInstruments.keys().

The method to return keys of the stored payment instruments in insertion order.

Related Spec Link:
 
https://w3c.github.io/webpayments-payment-handler/#paymentinstruments-interface

BUG=661608
==========

to

==========
PaymentHandler: Implement PaymentInstruments.keys().

The method to return keys of the stored payment instruments in insertion order.

Related Spec Link:
 
https://w3c.github.io/webpayments-payment-handler/#paymentinstruments-interface

BUG=661608
TEST=payment_manager_unittests.cc, payment-instruments.html
==========

[zino, 2017-05-01 17:39:56]

Description was changed from

==========
PaymentHandler: Implement PaymentInstruments.keys().

The method to return keys of the stored payment instruments in insertion order.

Related Spec Link:
 
https://w3c.github.io/webpayments-payment-handler/#paymentinstruments-interface

BUG=661608
TEST=payment_manager_unittests.cc, payment-instruments.html
==========

to

==========
PaymentHandler: Implement PaymentInstruments.keys().

The method to return keys of the stored payment instruments in insertion order.

Related Spec Link:
 
https://w3c.github.io/webpayments-payment-handler/#paymentinstruments-interface

BUG=661608
TEST=payment_manager_unittest.cc, payment-instruments.html
==========

[zino, 2017-05-01 17:41:14]

PTAL

rouslan@ for payments
Tom Sepez@ for mojom
nhiroki@ for service worker

Thank you.

[Tom Sepez, 2017-05-01 17:49:33]

https://codereview.chromium.org/2850203002/diff/20001/content/browser/payment...
File content/browser/payments/payment_manager_unittest.cc (right):

https://codereview.chromium.org/2850203002/diff/20001/content/browser/payment...
content/browser/payments/payment_manager_unittest.cc:265:
TEST_F(PaymentManagerTest, KeysOfPaymentInstruments) {
Maybe also test sending back an empty array to be sure that case is handled.

[please use gerrit instead, 2017-05-01 18:18:42]

payments lgtm % Tom's comment.

[nhiroki, 2017-05-02 01:21:12]

service worker lgtm

https://codereview.chromium.org/2850203002/diff/20001/content/browser/service...
File content/browser/service_worker/service_worker_database.h (right):

https://codereview.chromium.org/2850203002/diff/20001/content/browser/service...
content/browser/service_worker/service_worker_database.h:202: // Returns OK only
if all keys are found; otherwise NOT_FOUND, and
"all keys are found" sounds strange. Maybe "if keys matched to |key_prefix| are
found"?

[zino, 2017-05-02 15:03:58]

Thank you for review.

Tom Sepez@ PTAL

https://codereview.chromium.org/2850203002/diff/20001/content/browser/payment...
File content/browser/payments/payment_manager_unittest.cc (right):

https://codereview.chromium.org/2850203002/diff/20001/content/browser/payment...
content/browser/payments/payment_manager_unittest.cc:265:
TEST_F(PaymentManagerTest, KeysOfPaymentInstruments) {
On 2017/05/01 17:49:33, Tom Sepez wrote:
> Maybe also test sending back an empty array to be sure that case is handled.

Done.

https://codereview.chromium.org/2850203002/diff/20001/content/browser/service...
File content/browser/service_worker/service_worker_database.h (right):

https://codereview.chromium.org/2850203002/diff/20001/content/browser/service...
content/browser/service_worker/service_worker_database.h:202: // Returns OK only
if all keys are found; otherwise NOT_FOUND, and
On 2017/05/02 01:21:12, nhiroki (ooo May 3-7) wrote:
> "all keys are found" sounds strange. Maybe "if keys matched to |key_prefix|
are
> found"?

Done.

[Tom Sepez, 2017-05-02 16:11:58]

lgtm

[zino, 2017-05-02 18:00:29]

The CQ bit was checked by jinho.bang@samsung.com

[zino, 2017-05-02 18:00:30]

The patchset sent to the CQ was uploaded after l-g-t-m from
rouslan@chromium.org, nhiroki@chromium.org
Link to the patchset: https://codereview.chromium.org/2850203002/#ps40001
(title: "PaymentHandler: Implement PaymentInstruments.Keys().")

[commit-bot: I haz the power, 2017-05-02 18:00:56]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-02 19:45:02]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1493748029797310,
"parent_rev": "3f7bc3a7fd2911e29e1c1330bc2b815eeed8cb6c", "commit_rev":
"09c61ecc5adf140aa7a59aef0ecacc510e0be1d8"}

[commit-bot: I haz the power, 2017-05-02 19:45:10]

Description was changed from

==========
PaymentHandler: Implement PaymentInstruments.keys().

The method to return keys of the stored payment instruments in insertion order.

Related Spec Link:
 
https://w3c.github.io/webpayments-payment-handler/#paymentinstruments-interface

BUG=661608
TEST=payment_manager_unittest.cc, payment-instruments.html
==========

to

==========
PaymentHandler: Implement PaymentInstruments.keys().

The method to return keys of the stored payment instruments in insertion order.

Related Spec Link:
 
https://w3c.github.io/webpayments-payment-handler/#paymentinstruments-interface

BUG=661608
TEST=payment_manager_unittest.cc, payment-instruments.html

Review-Url: https://codereview.chromium.org/2850203002
Cr-Commit-Position: refs/heads/master@{#468747}
Committed:
https://chromium.googlesource.com/chromium/src/+/09c61ecc5adf140aa7a59aef0eca...
==========

[commit-bot: I haz the power, 2017-05-02 19:45:11]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/09c61ecc5adf140aa7a59aef0eca...

[findit-for-me, 2017-05-02 20:43:15]

Findit (https://goo.gl/kROfz5) identified this CL at revision 468747 as the
culprit for
failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...

[adithyas, 2017-05-02 21:19:35]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2858773002/ by adithyas@chromium.org.

The reason for reverting is: This patch is causing some PaymentManager tests to
fail..