Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2858623002: Remove MIPS support (Closed)

Created:
3 years, 7 months ago by zra
Modified:
3 years, 6 months ago
Reviewers:
Bill Hesse, siva
CC:
reviews_dartlang.org, turnidge, Cutch, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase #

Total comments: 3

Patch Set 5 : Merge and remove more references to mips #

Patch Set 6 : Remove warning messages #

Patch Set 7 : Further fixes #

Patch Set 8 : Merge, fix some comments, git cl format #

Patch Set 9 : Merge and cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -24400 lines) Patch
M CHANGELOG.md View 1 2 3 4 5 6 7 8 1 chunk +1 line, -0 lines 0 comments Download
D build/compiler_version.py View 1 chunk +0 lines, -143 lines 0 comments Download
M build/config/android/config.gni View 1 5 chunks +0 lines, -18 lines 0 comments Download
M build/config/compiler/BUILD.gn View 1 2 3 4 5 6 7 5 chunks +8 lines, -94 lines 0 comments Download
D build/config/gcc/gcc_version.gni View 1 chunk +0 lines, -26 lines 0 comments Download
D build/config/mips.gni View 1 chunk +0 lines, -43 lines 0 comments Download
M build/config/sysroot.gni View 1 chunk +0 lines, -4 lines 0 comments Download
M build/toolchain/android/BUILD.gn View 1 2 chunks +0 lines, -16 lines 0 comments Download
M build/toolchain/linux/BUILD.gn View 1 2 1 chunk +0 lines, -14 lines 0 comments Download
M pkg/pkg.status View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M runtime/BUILD.gn View 1 2 3 4 5 6 7 8 2 chunks +1 line, -3 lines 0 comments Download
M runtime/bin/platform.h View 1 2 3 4 5 6 7 8 2 chunks +1 line, -3 lines 0 comments Download
M runtime/observatory/tests/service/service.status View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/platform/globals.h View 1 2 3 4 5 6 7 8 8 chunks +8 lines, -30 lines 0 comments Download
M runtime/tools/benchmark.py View 3 chunks +3 lines, -3 lines 0 comments Download
M runtime/tools/gyp/runtime-configurations.gypi View 1 chunk +0 lines, -7 lines 0 comments Download
M runtime/vm/assembler.h View 2 chunks +1 line, -4 lines 0 comments Download
M runtime/vm/assembler.cc View 1 2 3 4 5 6 7 1 chunk +2 lines, -5 lines 0 comments Download
M runtime/vm/assembler_ia32.h View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
D runtime/vm/assembler_mips.h View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -1722 lines 0 comments Download
D runtime/vm/assembler_mips.cc View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -1410 lines 0 comments Download
D runtime/vm/assembler_mips_test.cc View 1 chunk +0 lines, -2323 lines 0 comments Download
M runtime/vm/assembler_x64.cc View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/atomic_linux.h View 1 chunk +0 lines, -5 lines 0 comments Download
D runtime/vm/code_patcher_mips.cc View 1 chunk +0 lines, -119 lines 0 comments Download
D runtime/vm/code_patcher_mips_test.cc View 1 2 1 chunk +0 lines, -62 lines 0 comments Download
M runtime/vm/compiler.cc View 1 2 3 4 5 6 7 8 1 chunk +4 lines, -5 lines 0 comments Download
D runtime/vm/constants_mips.h View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -644 lines 0 comments Download
M runtime/vm/cpu.h View 1 chunk +0 lines, -2 lines 0 comments Download
D runtime/vm/cpu_mips.h View 1 chunk +0 lines, -58 lines 0 comments Download
D runtime/vm/cpu_mips.cc View 1 chunk +0 lines, -109 lines 0 comments Download
M runtime/vm/cpu_test.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M runtime/vm/cpuinfo_android.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M runtime/vm/cpuinfo_linux.cc View 1 2 3 4 5 6 7 2 chunks +1 line, -9 lines 0 comments Download
M runtime/vm/dart.cc View 1 2 3 4 2 chunks +0 lines, -12 lines 0 comments Download
D runtime/vm/debugger_mips.cc View 1 chunk +0 lines, -64 lines 0 comments Download
M runtime/vm/deopt_instructions.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
D runtime/vm/disassembler_mips.cc View 1 chunk +0 lines, -792 lines 0 comments Download
D runtime/vm/flow_graph_compiler_mips.cc View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -1851 lines 0 comments Download
M runtime/vm/instructions.h View 1 chunk +0 lines, -2 lines 0 comments Download
D runtime/vm/instructions_mips.h View 1 chunk +0 lines, -134 lines 0 comments Download
D runtime/vm/instructions_mips.cc View 1 chunk +0 lines, -265 lines 0 comments Download
D runtime/vm/instructions_mips_test.cc View 1 chunk +0 lines, -36 lines 0 comments Download
M runtime/vm/intermediate_language.cc View 1 2 3 4 5 6 7 8 1 chunk +2 lines, -2 lines 0 comments Download
D runtime/vm/intermediate_language_mips.cc View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -5970 lines 0 comments Download
D runtime/vm/intrinsifier_mips.cc View 1 2 1 chunk +0 lines, -2444 lines 0 comments Download
D runtime/vm/malloc_hooks_mips.cc View 1 chunk +0 lines, -17 lines 0 comments Download
M runtime/vm/object.h View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -3 lines 0 comments Download
D runtime/vm/object_mips_test.cc View 1 chunk +0 lines, -55 lines 0 comments Download
M runtime/vm/os_android.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/os_fuchsia.cc View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/os_linux.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/os_macos.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/os_win.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/precompiler.cc View 1 2 3 4 5 6 7 8 1 chunk +4 lines, -5 lines 0 comments Download
M runtime/vm/profiler.cc View 1 2 3 4 5 6 7 8 2 chunks +1 line, -6 lines 0 comments Download
M runtime/vm/raw_object.h View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/regexp_assembler_ir.cc View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M runtime/vm/runtime_entry.h View 1 chunk +1 line, -1 line 0 comments Download
D runtime/vm/runtime_entry_mips.cc View 1 chunk +0 lines, -62 lines 0 comments Download
M runtime/vm/signal_handler_linux.cc View 4 chunks +0 lines, -8 lines 0 comments Download
M runtime/vm/simulator.h View 1 chunk +0 lines, -2 lines 0 comments Download
D runtime/vm/simulator_mips.h View 1 chunk +0 lines, -257 lines 0 comments Download
D runtime/vm/simulator_mips.cc View 1 1 chunk +0 lines, -2520 lines 0 comments Download
M runtime/vm/snapshot.cc View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -15 lines 0 comments Download
M runtime/vm/stack_frame.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
D runtime/vm/stack_frame_mips.h View 1 chunk +0 lines, -50 lines 0 comments Download
D runtime/vm/stub_code_mips.cc View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -2459 lines 0 comments Download
D runtime/vm/stub_code_mips_test.cc View 1 chunk +0 lines, -106 lines 0 comments Download
M runtime/vm/unit_test.h View 1 2 3 4 5 6 7 3 chunks +6 lines, -8 lines 0 comments Download
M runtime/vm/vm_sources.gypi View 1 2 3 4 5 6 7 15 chunks +0 lines, -23 lines 0 comments Download
M sdk/bin/dart View 1 2 3 4 5 6 7 1 chunk +2 lines, -2 lines 0 comments Download
M sdk/bin/pub View 1 2 3 4 5 6 7 1 chunk +2 lines, -2 lines 0 comments Download
M tests/co19/co19-runtime.status View 1 2 3 4 5 6 7 8 1 chunk +2 lines, -2 lines 0 comments Download
M tests/isolate/isolate.status View 1 2 3 4 1 chunk +0 lines, -3 lines 0 comments Download
M tests/language/language.status View 1 2 3 4 5 6 7 8 2 chunks +1 line, -5 lines 0 comments Download
M tests/standalone/io/test_extension_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M tests/standalone/standalone.status View 1 2 3 4 5 6 7 8 1 chunk +2 lines, -17 lines 0 comments Download
M third_party/pkg_tested/pkg_tested.status View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/tcmalloc/README.dart View 1 chunk +1 line, -1 line 0 comments Download
M tools/build.py View 1 2 3 4 5 6 7 5 chunks +3 lines, -12 lines 0 comments Download
M tools/gardening/lib/src/buildbot_data.dart View 1 2 3 4 1 chunk +0 lines, -12 lines 0 comments Download
M tools/gardening/lib/src/shard_data.dart View 1 2 3 4 3 chunks +0 lines, -6 lines 0 comments Download
M tools/gn.py View 1 2 3 4 5 6 7 chunks +8 lines, -20 lines 0 comments Download
M tools/gyp/configurations.gypi View 5 chunks +1 line, -103 lines 0 comments Download
M tools/gyp/configurations_make.gypi View 1 2 1 chunk +0 lines, -85 lines 0 comments Download
M tools/gyp/configurations_msvs.gypi View 1 chunk +0 lines, -3 lines 0 comments Download
M tools/gyp/configurations_xcode.gypi View 1 chunk +0 lines, -3 lines 0 comments Download
M tools/ninja.py View 1 2 3 4 5 4 chunks +3 lines, -10 lines 0 comments Download
M tools/sdks/README View 1 2 3 4 5 6 7 8 1 chunk +1 line, -2 lines 0 comments Download
M tools/testing/dart/compiler_configuration.dart View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -6 lines 0 comments Download
M tools/testing/dart/configuration.dart View 1 2 3 4 5 6 7 8 2 chunks +0 lines, -4 lines 0 comments Download
M tools/testing/dart/options.dart View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -1 line 0 comments Download
M tools/testing/dart/runtime_configuration.dart View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -2 lines 0 comments Download
M tools/testing/dart/status_reporter.dart View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M tools/utils.py View 1 3 chunks +1 line, -7 lines 0 comments Download
M utils/tests/peg/peg.status View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
zra
Not to be committed until we're ready to remove support.
3 years, 7 months ago (2017-05-02 17:20:14 UTC) #2
siva
LGTM with one comment. https://codereview.chromium.org/2858623002/diff/60001/build/compiler_version.py File build/compiler_version.py (left): https://codereview.chromium.org/2858623002/diff/60001/build/compiler_version.py#oldcode143 build/compiler_version.py:143: sys.exit(main(sys.argv)) Why is this not ...
3 years, 6 months ago (2017-06-02 15:56:15 UTC) #3
zra
https://codereview.chromium.org/2858623002/diff/60001/build/config/gcc/gcc_version.gni File build/config/gcc/gcc_version.gni (left): https://codereview.chromium.org/2858623002/diff/60001/build/config/gcc/gcc_version.gni#oldcode26 build/config/gcc/gcc_version.gni:26: } On 2017/06/02 15:56:15, siva wrote: > Ditto question ...
3 years, 6 months ago (2017-06-02 18:05:40 UTC) #4
zra
@whesse: This is ready to land as soon as mips/simmips is removed from the buildbot.
3 years, 6 months ago (2017-06-02 22:41:01 UTC) #5
Bill Hesse
On 2017/06/02 22:41:01, zra wrote: > @whesse: This is ready to land as soon as ...
3 years, 6 months ago (2017-06-06 13:19:31 UTC) #6
zra
Committed patchset #9 (id:160001) manually as ac16656161d8a525189e3f8ac3eaed0846f7b8f1 (presubmit successful).
3 years, 6 months ago (2017-06-22 15:49:28 UTC) #8
rmacnak
3 years, 6 months ago (2017-06-22 17:05:32 UTC) #9
Message was sent while issue was closed. 
On 2017/06/22 15:49:28, zra wrote:
> Committed patchset #9 (id:160001) manually as
> ac16656161d8a525189e3f8ac3eaed0846f7b8f1 (presubmit successful).

Goodbye :(

Powered by Google App Engine
This is Rietveld 408576698