build/config/gcc/gcc_version.gni - Issue 2858623002: Remove MIPS support

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: build/config/gcc/gcc_version.gni

Issue 2858623002: Remove MIPS support (Closed)

Patch Set: Rebase Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
	(Empty)
1 # Copyright 2014 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.

4

5 if (is_android) {

6 gcc_version = 49

7 } else if (current_toolchain == "//build/toolchain/cros:target" \|\|

8 current_toolchain == "//build/toolchain/linux:mipsel") {

9 gcc_version = exec_script("../../compiler_version.py",

10 [

11 "target",

12 "compiler",

13 ],

14 "value")

15 } else if (current_toolchain == "//build/toolchain/linux:x64" \|\|

16 current_toolchain == "//build/toolchain/linux:x86") {

17 # These are both the same and just use the default gcc on the system.

18 gcc_version = exec_script("../../compiler_version.py",

19 [

20 "host",

21 "compiler",

22 ],

23 "value")

24 } else {

25 gcc_version = 0

26 }
siva 2017/06/02 15:56:15 Ditto question about why this is not needed anymor Ditto question about why this is not needed anymore? zra 2017/06/02 18:05:39 gcc_version was only used to check whether one war Show quoted text On 2017/06/02 15:56:15, siva wrote: > Ditto question about why this is not needed anymore? gcc_version was only used to check whether one warning message should be ignored, but the VM was already clean w.r.t. that warning message.
OLD	NEW