Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 2858183002: bluetooth: Use String.repeat directly instead of generate_string. (Closed)

Created:
3 years, 7 months ago by ortuno
Modified:
3 years, 7 months ago
Reviewers:
scheib
CC:
chromium-reviews, blink-reviews, scheib+watch_chromium.org, ortuno+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

bluetooth: Use String.repeat directly instead of generate_string. Also removes generate_string BUG=569709 Review-Url: https://codereview.chromium.org/2858183002 Cr-Commit-Position: refs/heads/master@{#471234} Committed: https://chromium.googlesource.com/chromium/src/+/1bf1407c46eec2b7632a354f7db137303e005aac

Patch Set 1 #

Patch Set 2 : merge #

Patch Set 3 : Merge branch 'bluetooth-simulate-preconnected' into bluetooth-simulateconnecteddevice-followup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -21 lines) Patch
M third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/max-length-for-device-name-name.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/max-length-for-device-name-namePrefix.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/max-length-for-name-in-adv-name.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/max-length-for-name-in-adv-namePrefix.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/unicode-max-length-for-device-name-name.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/unicode-max-length-for-device-name-namePrefix.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/unicode-max-length-for-name-in-adv-name.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/unicode-max-length-for-name-in-adv-namePrefix.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/unicode-valid-length-name-name.html View 1 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/unicode-valid-length-name-namePrefix.html View 1 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/resources/bluetooth/bluetooth-helpers.js View 1 1 chunk +0 lines, -7 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 16 (13 generated)
scheib
lgtm
3 years, 7 months ago (2017-05-04 04:39:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2858183002/40001
3 years, 7 months ago (2017-05-12 06:05:03 UTC) #13
commit-bot: I haz the power
3 years, 7 months ago (2017-05-12 06:10:56 UTC) #16
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/1bf1407c46eec2b7632a354f7db1...

Powered by Google App Engine
This is Rietveld 408576698