third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/unicode-max-length-for-device-name-name.html - Issue 2858183002: bluetooth: Use String.repeat directly instead of generate_string.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/unicode-max-length-for-device-name-name.html

Issue 2858183002: bluetooth: Use String.repeat directly instead of generate_string. (Closed)

Patch Set: Merge branch 'bluetooth-simulate-preconnected' into bluetooth-simulateconnecteddevice-followup Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/max-length-for-name-in-adv-namePrefix.html ('k') | third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/unicode-max-length-for-device-name-namePrefix.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <script src="../../../resources/testharness.js"></script>	2 <script src="../../../resources/testharness.js"></script>

3 <script src="../../../resources/testharnessreport.js"></script>	3 <script src="../../../resources/testharnessreport.js"></script>

4 <script src="../../../resources/bluetooth/bluetooth-helpers.js"></script>	4 <script src="../../../resources/bluetooth/bluetooth-helpers.js"></script>

5 <script>	5 <script>

6 promise_test(() => {	6 promise_test(() => {

7 // \u2764's UTF-8 respresentation is 3 bytes long.	7 // \u2764's UTF-8 respresentation is 3 bytes long.

8 // 83 chars * 3 bytes/char = 249 bytes	8 // 83 chars * 3 bytes/char = 249 bytes

9 const unicode_name = generate_string(83, '\u2764');	9 const unicode_name = '\u2764'.repeat(83);

10 return assert_promise_rejects_with_message(	10 return assert_promise_rejects_with_message(

11 requestDeviceWithKeyDown({filters: [{name: unicode_name}]}),	11 requestDeviceWithKeyDown({filters: [{name: unicode_name}]}),

12 new DOMException(	12 new DOMException(

13 'Failed to execute \'requestDevice\' on \'Bluetooth\': ' +	13 'Failed to execute \'requestDevice\' on \'Bluetooth\': ' +

14 'A device name can\'t be longer than 248 bytes.',	14 'A device name can\'t be longer than 248 bytes.',

15 'TypeError'));	15 'TypeError'));

16 }, 'Unicode string with utf8 representation longer than 248 bytes in ' +	16 }, 'Unicode string with utf8 representation longer than 248 bytes in ' +

17 '\'name\' must throw TypeError.');	17 '\'name\' must throw TypeError.');

18 </script>	18 </script>

OLD	NEW