third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/max-length-for-name-in-adv-namePrefix.html - Issue 2858183002: bluetooth: Use String.repeat directly instead of generate_string.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/max-length-for-name-in-adv-namePrefix.html

Issue 2858183002: bluetooth: Use String.repeat directly instead of generate_string. (Closed)

Patch Set: Merge branch 'bluetooth-simulate-preconnected' into bluetooth-simulateconnecteddevice-followup Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <script src="../../../resources/testharness.js"></script>	2 <script src="../../../resources/testharness.js"></script>

3 <script src="../../../resources/testharnessreport.js"></script>	3 <script src="../../../resources/testharnessreport.js"></script>

4 <script src="../../../resources/bluetooth/bluetooth-helpers.js"></script>	4 <script src="../../../resources/bluetooth/bluetooth-helpers.js"></script>

5 <script>	5 <script>

6 'use strict';	6 'use strict';

7 promise_test(() => {	7 promise_test(() => {

8 let name_too_long = generate_string(249, 'a');	8 let name_too_long = 'a'.repeat(249);

9 return assert_promise_rejects_with_message(	9 return assert_promise_rejects_with_message(

10 requestDeviceWithKeyDown({filters: [{namePrefix: name_too_long}]}),	10 requestDeviceWithKeyDown({filters: [{namePrefix: name_too_long}]}),

11 new DOMException(	11 new DOMException(

12 'Failed to execute \'requestDevice\' on \'Bluetooth\': ' +	12 'Failed to execute \'requestDevice\' on \'Bluetooth\': ' +

13 'A device name can\'t be longer than 248 bytes.',	13 'A device name can\'t be longer than 248 bytes.',

14 'TypeError'),	14 'TypeError'),

15 'Device name prefix longer than 248');	15 'Device name prefix longer than 248');

16 }, 'A device name prefix longer than 248 must reject.');	16 }, 'A device name prefix longer than 248 must reject.');

17 </script>	17 </script>

OLD	NEW