Print Preview: Make getChildElement return required HTMLElement

Print Preview: Make getChildElement return required HTMLElement

In most locations callers assumed the function returned !HTMLElement
already. Changed the one location (in advanced_settings.js line 177)
that did not assume this to not call the function, and changed
getChildElement to return !HTMLElement.

Also removed some asserts that are no longer necessary.

This CL reduces print preview closure compiler errors to 180.

BUG=717620
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2857983007
Cr-Commit-Position: refs/heads/master@{#469564}
Committed: https://chromium.googlesource.com/chromium/src/+/04bee6a1d135e6665c04d1e748cf7baeb6769788

[rbpotter, 2017-05-04 22:42:09]

Description was changed from

==========
Make getChildElement return required HTMLElement

Also remove some asserts that are no longer necessary.
Reduces print preview closure compiler errors to 180

BUG=717620
==========

to

==========
Make getChildElement return required HTMLElement

Also remove some asserts that are no longer necessary.
Reduces print preview closure compiler errors to 180

BUG=717620
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[rbpotter, 2017-05-04 22:43:36]

The CQ bit was checked by rbpotter@chromium.org to run a CQ dry run

[rbpotter, 2017-05-04 22:43:48]

Description was changed from

==========
Make getChildElement return required HTMLElement

Also remove some asserts that are no longer necessary.
Reduces print preview closure compiler errors to 180

BUG=717620
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Make getChildElement return required HTMLElement

Also remove some asserts that are no longer necessary.
Reduces print preview closure compiler errors to 180

BUG=717620
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[rbpotter, 2017-05-04 22:43:48]

rbpotter@chromium.org changed reviewers:
+ dpapad@chromium.org

[commit-bot: I haz the power, 2017-05-04 22:44:39]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rbpotter, 2017-05-04 22:45:58]

Description was changed from

==========
Make getChildElement return required HTMLElement

Also remove some asserts that are no longer necessary.
Reduces print preview closure compiler errors to 180

BUG=717620
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Print Preview: Make getChildElement return required HTMLElement

In most locations callers assumed the function returned !HTMLElement
already. Changed the one location (in advanced_settings.js line 177)
that did not assume this to not call the function, and changed
getChildElement to return !HTMLElement.

Also removed some asserts that are no longer necessary.

This CL reduces print preview closure compiler errors to 180.

BUG=717620
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[rbpotter, 2017-05-04 22:46:48]

Followup CL to address getChildElement as requested in
https://codereview.chromium.org/2861713004/

[commit-bot: I haz the power, 2017-05-04 23:47:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-04 23:47:18]

Dry run: This issue passed the CQ dry run.

[dpapad, 2017-05-04 23:59:49]

LGTM with nits.

https://codereview.chromium.org/2857983007/diff/1/chrome/browser/resources/pr...
File chrome/browser/resources/print_preview/settings/color_settings.js (right):

https://codereview.chromium.org/2857983007/diff/1/chrome/browser/resources/pr...
chrome/browser/resources/print_preview/settings/color_settings.js:72: return /**
@type {!HTMLSelectElement} */(
You can probably remove the type cast now.

https://codereview.chromium.org/2857983007/diff/1/chrome/browser/resources/pr...
File chrome/browser/resources/print_preview/settings/layout_settings.js (right):

https://codereview.chromium.org/2857983007/diff/1/chrome/browser/resources/pr...
chrome/browser/resources/print_preview/settings/layout_settings.js:74: return
/** @type {!HTMLSelectElement} */(
Same here.

[rbpotter, 2017-05-05 00:47:56]

https://codereview.chromium.org/2857983007/diff/1/chrome/browser/resources/pr...
File chrome/browser/resources/print_preview/settings/color_settings.js (right):

https://codereview.chromium.org/2857983007/diff/1/chrome/browser/resources/pr...
chrome/browser/resources/print_preview/settings/color_settings.js:72: return /**
@type {!HTMLSelectElement} */(
On 2017/05/04 23:59:49, dpapad wrote:
> You can probably remove the type cast now.

According to the compiler, still need it to go from !HTMLElement to
!HTMLSelectElement. Should the return type be changed? Or leave the
type cast?

[dpapad, 2017-05-05 01:05:08]

https://codereview.chromium.org/2857983007/diff/1/chrome/browser/resources/pr...
File chrome/browser/resources/print_preview/settings/color_settings.js (right):

https://codereview.chromium.org/2857983007/diff/1/chrome/browser/resources/pr...
chrome/browser/resources/print_preview/settings/color_settings.js:72: return /**
@type {!HTMLSelectElement} */(
On 2017/05/05 at 00:47:56, rbpotter wrote:
> On 2017/05/04 23:59:49, dpapad wrote:
> > You can probably remove the type cast now.
> 
> According to the compiler, still need it to go from !HTMLElement to
> !HTMLSelectElement. Should the return type be changed? Or leave the
> type cast?

Ah, you are right. I misread (missed the "Select" part completely).

[rbpotter, 2017-05-05 01:15:38]

The CQ bit was checked by rbpotter@chromium.org

[commit-bot: I haz the power, 2017-05-05 01:16:18]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-05 01:22:16]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1493946938641740, "parent_rev":
"82cbc419c9725b0d7dddb403bce2f367638dfb35", "commit_rev":
"04bee6a1d135e6665c04d1e748cf7baeb6769788"}

[commit-bot: I haz the power, 2017-05-05 01:22:50]

Description was changed from

==========
Print Preview: Make getChildElement return required HTMLElement

In most locations callers assumed the function returned !HTMLElement
already. Changed the one location (in advanced_settings.js line 177)
that did not assume this to not call the function, and changed
getChildElement to return !HTMLElement.

Also removed some asserts that are no longer necessary.

This CL reduces print preview closure compiler errors to 180.

BUG=717620
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Print Preview: Make getChildElement return required HTMLElement

In most locations callers assumed the function returned !HTMLElement
already. Changed the one location (in advanced_settings.js line 177)
that did not assume this to not call the function, and changed
getChildElement to return !HTMLElement.

Also removed some asserts that are no longer necessary.

This CL reduces print preview closure compiler errors to 180.

BUG=717620
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2857983007
Cr-Commit-Position: refs/heads/master@{#469564}
Committed:
https://chromium.googlesource.com/chromium/src/+/04bee6a1d135e6665c04d1e748cf...
==========

[commit-bot: I haz the power, 2017-05-05 01:22:51]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/04bee6a1d135e6665c04d1e748cf...