Print Preview: Make getChildElement return required HTMLElement

chrome/browser/resources/print_preview/settings/color_settings.js

Index: chrome/browser/resources/print_preview/settings/color_settings.js
diff --git a/chrome/browser/resources/print_preview/settings/color_settings.js b/chrome/browser/resources/print_preview/settings/color_settings.js
index 5cc8562a9b83e1a876dd3f84e0d42ded6d1b7c3a..24d9cce57b72d762b01f94feeafa3f8257d6ad84 100644
--- a/chrome/browser/resources/print_preview/settings/color_settings.js
+++ b/chrome/browser/resources/print_preview/settings/color_settings.js
@@ -46,7 +46,7 @@ cr.define('print_preview', function() {
     enterDocument: function() {
       print_preview.SettingsSection.prototype.enterDocument.call(this);
       this.tracker.add(
-          assert(this.select_), 'change', this.onSelectChange_.bind(this));
+          this.select_, 'change', this.onSelectChange_.bind(this));
       this.tracker.add(
           this.colorTicketItem_,
           print_preview.ticket_items.TicketItem.EventType.CHANGE,
@@ -65,11 +65,11 @@ cr.define('print_preview', function() {
     },
 
     /**
-     * @return {HTMLSelectElement} Select element containing the color options.
+     * @return {!HTMLSelectElement} Select element containing the color options.
      * @private
      */
     get select_() {
-      return /** @type {HTMLSelectElement} */(
+      return /** @type {!HTMLSelectElement} */(

[dpapad, 2017/05/04 23:59:49]

You can probably remove the type cast now.

[rbpotter, 2017/05/05 00:47:56]

According to the compiler, still need it to go from !HTMLElement to
!HTMLSelectElement. Should the return type be changed? Or leave the
type cast?

[dpapad, 2017/05/05 01:05:08]

Ah, you are right. I misread (missed the "Select" part completely).

           this.getChildElement('.color-settings-select'));
     },