Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(904)

Unified Diff: chrome/browser/resources/print_preview/settings/layout_settings.js

Issue 2857983007: Print Preview: Make getChildElement return required HTMLElement (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/print_preview/settings/layout_settings.js
diff --git a/chrome/browser/resources/print_preview/settings/layout_settings.js b/chrome/browser/resources/print_preview/settings/layout_settings.js
index 1113491b7dd9c0819f8231fb3c84c84996cbbbd4..cd1aeed5fcbf9e715615168817e7be651ed0599d 100644
--- a/chrome/browser/resources/print_preview/settings/layout_settings.js
+++ b/chrome/browser/resources/print_preview/settings/layout_settings.js
@@ -46,7 +46,7 @@ cr.define('print_preview', function() {
enterDocument: function() {
print_preview.SettingsSection.prototype.enterDocument.call(this);
this.tracker.add(
- assert(this.select_), 'change', this.onSelectChange_.bind(this));
+ this.select_, 'change', this.onSelectChange_.bind(this));
this.tracker.add(
this.landscapeTicketItem_,
print_preview.ticket_items.TicketItem.EventType.CHANGE,
@@ -66,11 +66,12 @@ cr.define('print_preview', function() {
},
/**
- * @return {HTMLSelectElement} Select element containing the layout options.
+ * @return {!HTMLSelectElement} Select element containing the layout
+ * options.
* @private
*/
get select_() {
- return /** @type {HTMLSelectElement} */(
+ return /** @type {!HTMLSelectElement} */(
dpapad 2017/05/04 23:59:49 Same here.
this.getChildElement('.layout-settings-select'));
},

Powered by Google App Engine
This is Rietveld 408576698