Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 2856863006: [Devtools] Fix network grouping experiment (Closed)

Created:
3 years, 7 months ago by allada
Modified:
3 years, 7 months ago
Reviewers:
dgozman, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Devtools] Fix network grouping experiment There was a regression recently that was fixed (https://codereview.chromium.org/2838673003/) but broke the network grouping experiment. This patch fixes that regression. We were deeming the item as not needing to be removed or added without checking if there is a new parent. R=dgozman,pfeldman BUG=718116 Review-Url: https://codereview.chromium.org/2856863006 Cr-Commit-Position: refs/heads/master@{#469250} Committed: https://chromium.googlesource.com/chromium/src/+/0e9adc6c75e97b47626520733f9a6ac3b3c010ef

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js View 1 chunk +1 line, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (4 generated)
allada
PTL
3 years, 7 months ago (2017-05-03 18:48:15 UTC) #1
dgozman
lgtm
3 years, 7 months ago (2017-05-03 21:33:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2856863006/1
3 years, 7 months ago (2017-05-04 01:08:41 UTC) #4
commit-bot: I haz the power
3 years, 7 months ago (2017-05-04 02:41:00 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0e9adc6c75e97b47626520733f9a...

Powered by Google App Engine
This is Rietveld 408576698