Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js

Issue 2856863006: [Devtools] Fix network grouping experiment (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js b/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
index 9b9910b5b3e9d534b1fccb11d2f728ab8d871daa..c641e6ee02faf27f46ae7f0481d817a82097a850 100644
--- a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
+++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
@@ -843,10 +843,10 @@ Network.NetworkLogView = class extends UI.VBox {
var request = node.request();
this._timeCalculator.updateBoundaries(request);
this._durationCalculator.updateBoundaries(request);
- if (node[Network.NetworkLogView._isFilteredOutSymbol] === isFilteredOut)
+ var newParent = this._parentNodeForInsert(node);
+ if (node[Network.NetworkLogView._isFilteredOutSymbol] === isFilteredOut && node.parent === newParent)
continue;
node[Network.NetworkLogView._isFilteredOutSymbol] = isFilteredOut;
- var newParent = this._parentNodeForInsert(node);
var removeFromParent = node.parent && (isFilteredOut || node.parent !== newParent);
if (removeFromParent) {
var parent = node.parent;
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698