[Devtools] Restructure network nodes for friendlier products/grouping

[Devtools] Restructure network nodes for friendlier products/grouping

Restructures how NetworkNodes are managed to push more of the code into
the individual implementations of the NetworkGrouper. Grouper is now
more like a factory for a NetworkNode.

In the case here, we are setting up FrameGroupNode as an extension of
NetworkGroupNode which is a lightweight wrapper for groupable items.
When a cell is being rendered we are now able to intercept the calls and
render them with special content (like we do here with product and name
column).

R=pfeldman,dgozman
BUG=718236
Review-Url: https://codereview.chromium.org/2859063003
Cr-Commit-Position: refs/heads/master@{#469583}
Committed: https://chromium.googlesource.com/chromium/src/+/ed10e8d7378176b6346982f08e0930d18069f99e

[allada, 2017-05-04 00:40:02]

PTL

[allada, 2017-05-04 00:40:08]

Patchset #1 (id:1) has been deleted

[allada, 2017-05-04 00:40:14]

Patchset #1 (id:20001) has been deleted

[allada, 2017-05-04 00:40:20]

Patchset #1 (id:40001) has been deleted

[allada, 2017-05-04 00:40:26]

Patchset #1 (id:60001) has been deleted

[allada, 2017-05-04 00:50:03]

Patchset #1 (id:80001) has been deleted

[allada, 2017-05-04 00:50:08]

Patchset #1 (id:100001) has been deleted

[pfeldman, 2017-05-04 22:54:08]

https://codereview.chromium.org/2859063003/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/devtools/front_end/network/NetworkFrameGrouper.js
(right):

https://codereview.chromium.org/2859063003/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/network/NetworkFrameGrouper.js:110:
_getEntry() {
_entry

https://codereview.chromium.org/2859063003/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
(right):

https://codereview.chromium.org/2859063003/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js:373:
this._activeGroupLookup.reset();
Do you clean your map when I clear network panel?

https://codereview.chromium.org/2859063003/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js (right):

https://codereview.chromium.org/2859063003/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js:168:
resourceTreeFrame() {
I would not depend on RTM here, the dependency goes the other way around. Move
this into RTM itself or into the call site.

[allada, 2017-05-05 00:43:13]

PTaL

https://codereview.chromium.org/2859063003/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/devtools/front_end/network/NetworkFrameGrouper.js
(right):

https://codereview.chromium.org/2859063003/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/network/NetworkFrameGrouper.js:110:
_getEntry() {
On 2017/05/04 22:54:08, pfeldman wrote:
> _entry

Done.

https://codereview.chromium.org/2859063003/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
(right):

https://codereview.chromium.org/2859063003/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js:373:
this._activeGroupLookup.reset();
On 2017/05/04 22:54:08, pfeldman wrote:
> Do you clean your map when I clear network panel?

Yes, the button calls NetworkPanel._reset() which calls NetworkLogView.reset()
which resets it if it is set.

https://codereview.chromium.org/2859063003/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js (right):

https://codereview.chromium.org/2859063003/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js:168:
resourceTreeFrame() {
On 2017/05/04 22:54:08, pfeldman wrote:
> I would not depend on RTM here, the dependency goes the other way around. Move
> this into RTM itself or into the call site.

Done. It makes the code really ugly if I inline it.

[pfeldman, 2017-05-05 00:51:18]

lgtm

[allada, 2017-05-05 00:52:34]

The CQ bit was checked by allada@chromium.org

[commit-bot: I haz the power, 2017-05-05 00:53:12]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-05 03:15:06]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1493945554305740,
"parent_rev": "32a9e92ea1f387e91a9f7b87e19ce48f3990404c", "commit_rev":
"ed10e8d7378176b6346982f08e0930d18069f99e"}

[commit-bot: I haz the power, 2017-05-05 03:15:18]

Description was changed from

==========
[Devtools] Restructure network nodes for friendlier products/grouping

Restructures how NetworkNodes are managed to push more of the code into
the individual implementations of the NetworkGrouper. Grouper is now
more like a factory for a NetworkNode.

In the case here, we are setting up FrameGroupNode as an extension of
NetworkGroupNode which is a lightweight wrapper for groupable items.
When a cell is being rendered we are now able to intercept the calls and
render them with special content (like we do here with product and name
column).

R=pfeldman,dgozman
BUG=718236
==========

to

==========
[Devtools] Restructure network nodes for friendlier products/grouping

Restructures how NetworkNodes are managed to push more of the code into
the individual implementations of the NetworkGrouper. Grouper is now
more like a factory for a NetworkNode.

In the case here, we are setting up FrameGroupNode as an extension of
NetworkGroupNode which is a lightweight wrapper for groupable items.
When a cell is being rendered we are now able to intercept the calls and
render them with special content (like we do here with product and name
column).

R=pfeldman,dgozman
BUG=718236

Review-Url: https://codereview.chromium.org/2859063003
Cr-Commit-Position: refs/heads/master@{#469583}
Committed:
https://chromium.googlesource.com/chromium/src/+/ed10e8d7378176b6346982f08e09...
==========

[commit-bot: I haz the power, 2017-05-05 03:15:19]

Committed patchset #2 (id:140001) as
https://chromium.googlesource.com/chromium/src/+/ed10e8d7378176b6346982f08e09...