Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 2855993002: Revert of Adding Daydream controller resources for VrShell (Closed)

Created:
3 years, 7 months ago by jbroman
Modified:
3 years, 7 months ago
Reviewers:
acondor_, mthiesse, Nico, agrieve
CC:
chromium-reviews, feature-vr-reviews_chromium.org, arv+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Adding Daydream controller resources for VrShell (patchset #4 id:60001 of https://codereview.chromium.org/2850893002/ ) Reason for revert: Broke Android Builder: https://build.chromium.org/p/chromium.linux/builders/Android%20Builder/builds/82535 Original issue's description: > Adding Daydream controller resources for VrShell > > - Model is in binary glTF format with no inline shaders. > - Textures are composed by one base texture and three patches of minimal size. > - We also considered using WebP, but decoders are implemented only within blink. > - Monochrome APK size is increased by 40Kb. > > BUG=644562 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation > > Review-Url: https://codereview.chromium.org/2850893002 > Cr-Commit-Position: refs/heads/master@{#468806} > Committed: https://chromium.googlesource.com/chromium/src/+/c5582157f1ac2b92e412e5164c3fd49088fd7fff TBR=mthiesse@chromium.org,agrieve@chromium.org,thakis@chromium.org,acondor@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=644562 Review-Url: https://codereview.chromium.org/2855993002 Cr-Commit-Position: refs/heads/master@{#468811} Committed: https://chromium.googlesource.com/chromium/src/+/2d681dd33b7f69bb34549ff3ff1a95898e0815f6

Patch Set 1 #

Messages

Total messages: 6 (3 generated)
jbroman
Created Revert of Adding Daydream controller resources for VrShell
3 years, 7 months ago (2017-05-02 23:23:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2855993002/1
3 years, 7 months ago (2017-05-02 23:24:05 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-05-02 23:24:51 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2d681dd33b7f69bb34549ff3ff1a...

Powered by Google App Engine
This is Rietveld 408576698