Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 2850893002: Adding Daydream controller resources for VrShell (Closed)

Created:
3 years, 7 months ago by acondor_
Modified:
3 years, 7 months ago
Reviewers:
mthiesse, Nico, agrieve
CC:
chromium-reviews, feature-vr-reviews_chromium.org, arv+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Adding Daydream controller resources for VrShell - Model is in binary glTF format with no inline shaders. - Textures are composed by one base texture and three patches of minimal size. - We also considered using WebP, but decoders are implemented only within blink. - Monochrome APK size is increased by 40Kb. BUG=644562 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2850893002 Cr-Original-Commit-Position: refs/heads/master@{#468806} Committed: https://chromium.googlesource.com/chromium/src/+/c5582157f1ac2b92e412e5164c3fd49088fd7fff Review-Url: https://codereview.chromium.org/2850893002 Cr-Commit-Position: refs/heads/master@{#469051} Committed: https://chromium.googlesource.com/chromium/src/+/a62b93177432b09f7b287b0c3482a735ba9dc13b

Patch Set 1 #

Patch Set 2 : grdp file for vr_shell resources #

Total comments: 8

Patch Set 3 : suggestions #

Patch Set 4 : Removing logo from texture #

Patch Set 5 : Adding dep #

Messages

Total messages: 39 (16 generated)
acondor_
PTAL
3 years, 7 months ago (2017-04-28 19:15:36 UTC) #3
acondor_
Hello agrieve+, PTAL
3 years, 7 months ago (2017-04-28 19:42:02 UTC) #6
agrieve
On 2017/04/28 19:42:02, acondor wrote: > Hello agrieve+, PTAL I think it'd be worth listing ...
3 years, 7 months ago (2017-04-28 19:55:20 UTC) #7
mthiesse
On 2017/04/28 19:55:20, agrieve wrote: > On 2017/04/28 19:42:02, acondor wrote: > > Hello agrieve+, ...
3 years, 7 months ago (2017-04-28 19:59:59 UTC) #8
agrieve
On 2017/04/28 19:59:59, mthiesse wrote: > On 2017/04/28 19:55:20, agrieve wrote: > > On 2017/04/28 ...
3 years, 7 months ago (2017-04-28 20:17:55 UTC) #9
acondor_
I added a grdp file as suggested. +thakis PTAL
3 years, 7 months ago (2017-05-01 15:38:55 UTC) #12
mthiesse
vr_shell/ lgtm
3 years, 7 months ago (2017-05-01 15:46:07 UTC) #13
Nico
Folks are fine with adding resources with Google logos to the public repo, yes? In ...
3 years, 7 months ago (2017-05-01 17:21:43 UTC) #14
acondor_
> Folks are fine with adding resources with Google logos to > the public repo, ...
3 years, 7 months ago (2017-05-02 18:18:24 UTC) #15
Nico
On Tue, May 2, 2017 at 2:18 PM, <acondor@google.com> wrote: > > Folks are fine ...
3 years, 7 months ago (2017-05-02 20:26:23 UTC) #16
mthiesse
On 2017/05/02 20:26:23, Nico wrote: > On Tue, May 2, 2017 at 2:18 PM, <mailto:acondor@google.com> ...
3 years, 7 months ago (2017-05-02 20:40:57 UTC) #17
Nico
On Tue, May 2, 2017 at 4:40 PM, <mthiesse@chromium.org> wrote: > On 2017/05/02 20:26:23, Nico ...
3 years, 7 months ago (2017-05-02 20:44:28 UTC) #18
bajones
Would it be unreasonable to scrub the Google logo off the back of the asset ...
3 years, 7 months ago (2017-05-02 20:47:35 UTC) #19
mthiesse
On 2017/05/02 20:47:35, bajones wrote: > Would it be unreasonable to scrub the Google logo ...
3 years, 7 months ago (2017-05-02 20:58:00 UTC) #20
Nico
lgtm with logo scrubbed or if some lawyer-y person signs off on this somewhere
3 years, 7 months ago (2017-05-02 21:00:23 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2850893002/60001
3 years, 7 months ago (2017-05-02 21:29:28 UTC) #24
commit-bot: I haz the power
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/src/+/c5582157f1ac2b92e412e5164c3fd49088fd7fff
3 years, 7 months ago (2017-05-02 22:54:47 UTC) #27
jbroman
A revert of this CL (patchset #4 id:60001) has been created in https://codereview.chromium.org/2855993002/ by jbroman@chromium.org. ...
3 years, 7 months ago (2017-05-02 23:23:31 UTC) #28
findit-for-me
Findit (https://goo.gl/kROfz5) confirmed this CL at revision 468806 as the culprit for failures in the ...
3 years, 7 months ago (2017-05-02 23:29:33 UTC) #29
acondor_
PTAL
3 years, 7 months ago (2017-05-03 16:53:10 UTC) #32
mthiesse
lgtm Make sure to watch the builder (https://build.chromium.org/p/chromium.linux/builders/Android%20Builder) when you try to re-land this, and ...
3 years, 7 months ago (2017-05-03 17:00:42 UTC) #34
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2850893002/100001
3 years, 7 months ago (2017-05-03 17:01:27 UTC) #36
commit-bot: I haz the power
3 years, 7 months ago (2017-05-03 18:48:06 UTC) #39
Message was sent while issue was closed.
Committed patchset #5 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/a62b93177432b09f7b287b0c3482...

Powered by Google App Engine
This is Rietveld 408576698