Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2855843002: Reland "Sync requestFullscreen() and exitFullscreen() algorithms with the spec" (Closed)

Created:
3 years, 7 months ago by foolip
Modified:
3 years, 6 months ago
Reviewers:
CC:
chromium-reviews, shans, szager+layoutwatch_chromium.org, eae+blinkwatch, fs, eric.carlson_apple.com, apavlov+blink_chromium.org, Srirama, kinuko+watch, rwlbuis, blink-reviews-css, blink-reviews-html_chromium.org, blink-reviews-dom_chromium.org, dglazkov+blink, jchaffraix+rendering, blink-reviews, Eric Willigers, blink-reviews-w3ctests_chromium.org, nessy, rjwright, blink-reviews-style_chromium.org, zoltan1, blink-reviews-layout_chromium.org, sof, feature-media-reviews_chromium.org, dcheng, darktears, haraken, mlamouri+watch-blink_chromium.org, blink-reviews-animation_chromium.org, pdr+renderingwatchlist_chromium.org, gasubic, leviw+renderwatch
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland "Sync requestFullscreen() and exitFullscreen() algorithms with the spec" This relands https://codereview.chromium.org/2573773002/, which was reverted in https://codereview.chromium.org/2654083006/. BUG=402376, 402421 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Patch Set 1 #

Patch Set 2 : expect test to fail #

Patch Set 3 : Add back from_element/to_element #

Patch Set 4 : Separate state transition from events #

Patch Set 5 : Reland "Sync requestFullscreen() and exitFullscreen() algorithms with the spec" #

Unified diffs Side-by-side diffs Delta from patch set Stats (+755 lines, -940 lines) Patch
M third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG View 1 2 3 4 4 chunks +2 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 3 4 1 chunk +0 lines, -4 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/fullscreen/api/document-exit-fullscreen-nested-in-iframe-manual-expected.txt View 1 1 chunk +4 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/external/wpt/fullscreen/api/document-exit-fullscreen-twice-manual-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D third_party/WebKit/LayoutTests/external/wpt/fullscreen/api/document-fullscreen-element-manual-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D third_party/WebKit/LayoutTests/external/wpt/fullscreen/api/element-request-fullscreen-and-move-manual-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D third_party/WebKit/LayoutTests/external/wpt/fullscreen/api/element-request-fullscreen-and-move-to-iframe-manual-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D third_party/WebKit/LayoutTests/external/wpt/fullscreen/api/element-request-fullscreen-and-remove-iframe-manual-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D third_party/WebKit/LayoutTests/external/wpt/fullscreen/api/element-request-fullscreen-and-remove-manual-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D third_party/WebKit/LayoutTests/external/wpt/fullscreen/api/element-request-fullscreen-twice-manual-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D third_party/WebKit/LayoutTests/fullscreen/api/document-exit-fullscreen-twice.html View 1 2 3 4 1 chunk +0 lines, -34 lines 0 comments Download
M third_party/WebKit/LayoutTests/fullscreen/api/document-exit-fullscreen-vs-request.html View 1 2 3 4 2 chunks +16 lines, -11 lines 0 comments Download
D third_party/WebKit/LayoutTests/fullscreen/api/document-fullscreen-element.html View 1 2 3 4 1 chunk +0 lines, -36 lines 0 comments Download
D third_party/WebKit/LayoutTests/fullscreen/api/element-request-fullscreen-and-move.html View 1 2 3 4 1 chunk +0 lines, -27 lines 0 comments Download
D third_party/WebKit/LayoutTests/fullscreen/api/element-request-fullscreen-and-move-to-iframe.html View 1 2 3 4 1 chunk +0 lines, -29 lines 0 comments Download
A third_party/WebKit/LayoutTests/fullscreen/api/element-request-fullscreen-and-move-to-iframe-prefixed.html View 1 2 3 4 1 chunk +28 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/fullscreen/api/element-request-fullscreen-and-remove.html View 1 2 3 4 1 chunk +0 lines, -24 lines 0 comments Download
D third_party/WebKit/LayoutTests/fullscreen/api/element-request-fullscreen-and-remove-iframe.html View 1 2 3 4 1 chunk +0 lines, -28 lines 0 comments Download
A third_party/WebKit/LayoutTests/fullscreen/api/element-request-fullscreen-and-remove-prefixed.html View 1 2 3 4 1 chunk +23 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/fullscreen/api/element-request-fullscreen-twice.html View 1 2 3 4 1 chunk +0 lines, -29 lines 0 comments Download
M third_party/WebKit/LayoutTests/fullscreen/api/element-request-fullscreen-two-iframes.html View 1 2 3 4 1 chunk +7 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/fullscreen/api/element-request-fullscreen-vs-exit.html View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fullscreen/enter-exit-full-screen-hover.html View 4 1 chunk +23 lines, -15 lines 0 comments Download
M third_party/WebKit/LayoutTests/fullscreen/enter-exit-full-screen-hover-expected.txt View 4 1 chunk +2 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/fullscreen/full-screen-remove-ancestor-during-transition.html View 1 chunk +0 lines, -40 lines 0 comments Download
D third_party/WebKit/LayoutTests/fullscreen/full-screen-remove-ancestor-during-transition-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/fullscreen/full-screen-stacking-context.html View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSDefaultStyleSheets.cpp View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/SelectorChecker.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/DocumentFullscreen.h View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DocumentFullscreen.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DocumentFullscreen.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Element.cpp View 1 2 3 4 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Fullscreen.h View 1 2 3 4 6 chunks +33 lines, -51 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Fullscreen.cpp View 1 2 3 4 9 chunks +496 lines, -444 lines 0 comments Download
M third_party/WebKit/Source/core/dom/LayoutTreeBuilder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/exported/WebViewBase.h View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLMediaElement.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLVideoElement.cpp View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLVideoElementPersistentTest.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/media/MediaCustomControlsFullscreenDetector.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutInline.cpp View 1 2 3 4 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp View 1 2 3 4 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/page/ChromeClient.h View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/media_controls/MediaControlsOrientationLockDelegateTest.cpp View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/media_controls/MediaControlsRotateToFullscreenDelegate.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/media_controls/MediaControlsRotateToFullscreenDelegateTest.cpp View 1 2 3 4 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/ChromeClientImpl.h View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/FullscreenController.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/FullscreenController.cpp View 1 2 3 4 4 chunks +24 lines, -22 lines 0 comments Download
M third_party/WebKit/Source/web/WebPluginContainerImpl.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp View 1 2 3 4 1 chunk +10 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.h View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/WebFrameTest.cpp View 1 2 3 4 16 chunks +41 lines, -43 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebViewTest.cpp View 1 2 3 4 7 chunks +10 lines, -1 line 0 comments Download

Messages

Total messages: 10 (10 generated)
foolip
Description was changed from ========== Reland "Sync requestFullscreen() and exitFullscreen() algorithms with the spec" This ...
3 years, 7 months ago (2017-05-02 11:25:55 UTC) #1
foolip
The CQ bit was checked by foolip@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-02 11:48:35 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2855843002/20001
3 years, 7 months ago (2017-05-02 11:48:48 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-02 12:53:38 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/443171)
3 years, 7 months ago (2017-05-02 12:53:38 UTC) #5
foolip
The CQ bit was checked by foolip@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-03 11:37:08 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2855843002/60001
3 years, 7 months ago (2017-05-03 11:37:20 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-03 13:36:44 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
3 years, 7 months ago (2017-05-03 13:36:45 UTC) #9
foolip
3 years, 6 months ago (2017-06-01 11:20:30 UTC) #10 
Description was changed from

==========
Reland "Sync requestFullscreen() and exitFullscreen() algorithms with the spec"

This relands https://codereview.chromium.org/2573773002/, which was
reverted in https://codereview.chromium.org/2654083006/.

BUG=402376,402421
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Reland "Sync requestFullscreen() and exitFullscreen() algorithms with the spec"

This relands https://codereview.chromium.org/2573773002/, which was
reverted in https://codereview.chromium.org/2654083006/.

BUG=402376,402421
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

Powered by Google App Engine
This is Rietveld 408576698