third_party/WebKit/Source/modules/media_controls/MediaControlsRotateToFullscreenDelegateTest.cpp - Issue 2855843002: Reland "Sync requestFullscreen() and exitFullscreen() algorithms with the spec"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/media_controls/MediaControlsRotateToFullscreenDelegateTest.cpp

Issue 2855843002: Reland "Sync requestFullscreen() and exitFullscreen() algorithms with the spec" (Closed)

Patch Set: Reland "Sync requestFullscreen() and exitFullscreen() algorithms with the spec" Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/media_controls/MediaControlsRotateToFullscreenDelegate.cpp ('k') | third_party/WebKit/Source/web/ChromeClientImpl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/media_controls/MediaControlsRotateToFullscreenDelegateTest.cpp

diff --git a/third_party/WebKit/Source/modules/media_controls/MediaControlsRotateToFullscreenDelegateTest.cpp b/third_party/WebKit/Source/modules/media_controls/MediaControlsRotateToFullscreenDelegateTest.cpp

index c727e7962728870d41e8c6ac3a269926b5cc1fd5..1b67035923ccd9a42ee5d63438f153d5ef3104ed 100644

--- a/third_party/WebKit/Source/modules/media_controls/MediaControlsRotateToFullscreenDelegateTest.cpp

+++ b/third_party/WebKit/Source/modules/media_controls/MediaControlsRotateToFullscreenDelegateTest.cpp

@@ -563,7 +563,7 @@ TEST_F(MediaControlsRotateToFullscreenDelegateTest,

Fullscreen::RequestFullscreen(*GetDocument().body());

}

testing::RunPendingTasks();

- EXPECT_TRUE(Fullscreen::IsCurrentFullScreenElement(*GetDocument().body()));

+ EXPECT_TRUE(Fullscreen::IsFullscreenElement(*GetDocument().body()));

EXPECT_FALSE(GetVideo().IsFullscreen());

// Play video.

@@ -576,7 +576,7 @@ TEST_F(MediaControlsRotateToFullscreenDelegateTest,

RotateTo(kWebScreenOrientationLandscapePrimary);

// Should not enter fullscreen on video, since document is already fullscreen.

- EXPECT_TRUE(Fullscreen::IsCurrentFullScreenElement(*GetDocument().body()));

+ EXPECT_TRUE(Fullscreen::IsFullscreenElement(*GetDocument().body()));

EXPECT_FALSE(GetVideo().IsFullscreen());

}

@@ -654,7 +654,7 @@ TEST_F(MediaControlsRotateToFullscreenDelegateTest,

Fullscreen::RequestFullscreen(*GetDocument().body());

}

testing::RunPendingTasks();

- EXPECT_TRUE(Fullscreen::IsCurrentFullScreenElement(*GetDocument().body()));

+ EXPECT_TRUE(Fullscreen::IsFullscreenElement(*GetDocument().body()));

EXPECT_FALSE(GetVideo().IsFullscreen());

// Leave video paused (playing is not a requirement to exit fullscreen).

@@ -665,7 +665,7 @@ TEST_F(MediaControlsRotateToFullscreenDelegateTest,

RotateTo(kWebScreenOrientationPortraitPrimary);

// Should not exit fullscreen, since video was not the fullscreen element.

- EXPECT_TRUE(Fullscreen::IsCurrentFullScreenElement(*GetDocument().body()));

+ EXPECT_TRUE(Fullscreen::IsFullscreenElement(*GetDocument().body()));

EXPECT_FALSE(GetVideo().IsFullscreen());

}