third_party/WebKit/Source/modules/media_controls/MediaControlsOrientationLockDelegateTest.cpp - Issue 2855843002: Reland "Sync requestFullscreen() and exitFullscreen() algorithms with the spec"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/media_controls/MediaControlsOrientationLockDelegateTest.cpp

Issue 2855843002: Reland "Sync requestFullscreen() and exitFullscreen() algorithms with the spec" (Closed)

Patch Set: Reland "Sync requestFullscreen() and exitFullscreen() algorithms with the spec" Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/page/ChromeClient.h ('k') | third_party/WebKit/Source/modules/media_controls/MediaControlsRotateToFullscreenDelegate.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/media_controls/MediaControlsOrientationLockDelegateTest.cpp

diff --git a/third_party/WebKit/Source/modules/media_controls/MediaControlsOrientationLockDelegateTest.cpp b/third_party/WebKit/Source/modules/media_controls/MediaControlsOrientationLockDelegateTest.cpp

index a2a5f88ad450be47151a743dc59bccb0f1fa244f..0990d44f3e655845c58835c34561b8c2496a44f0 100644

--- a/third_party/WebKit/Source/modules/media_controls/MediaControlsOrientationLockDelegateTest.cpp

+++ b/third_party/WebKit/Source/modules/media_controls/MediaControlsOrientationLockDelegateTest.cpp

@@ -140,13 +140,13 @@ class MediaControlsOrientationLockDelegateTest : public ::testing::Test {

Fullscreen::RequestFullscreen(Video());

Fullscreen::From(GetDocument()).DidEnterFullscreen();

- testing::RunPendingTasks();

+ GetDocument().ServiceScriptedAnimations(WTF::MonotonicallyIncreasingTime());

}

void SimulateExitFullscreen() {

Fullscreen::ExitFullscreen(GetDocument());

Fullscreen::From(GetDocument()).DidExitFullscreen();

- testing::RunPendingTasks();

+ GetDocument().ServiceScriptedAnimations(WTF::MonotonicallyIncreasingTime());

}

void SimulateOrientationLock() {