Reland "Sync requestFullscreen() and exitFullscreen() algorithms with the spec"

third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "web/WebRemoteFrameImpl.h"
 
 #include "bindings/core/v8/WindowProxy.h"
 #include "core/dom/Fullscreen.h"
 #include "core/dom/RemoteSecurityContext.h"
 #include "core/dom/SecurityContext.h"
@@ skipping 475 matching lines @@
     return false;
   return owner->GetLayoutObject()->Style()->PointerEvents() ==
          EPointerEvents::kNone;
 }
 
 void WebRemoteFrameImpl::WillEnterFullscreen() {
   // This should only ever be called when the FrameOwner is local.
   HTMLFrameOwnerElement* owner_element =
       ToHTMLFrameOwnerElement(GetFrame()->Owner());
 
-  // Call requestFullscreen() on |ownerElement| to make it the provisional
-  // fullscreen element in FullscreenController, and to prepare
-  // fullscreenchange events that will need to fire on it and its (local)
-  // ancestors. The events will be triggered if/when fullscreen is entered.
+  // Call |requestFullscreen()| on |ownerElement| to make it the pending
+  // fullscreen element in anticipation of the coming |didEnterFullscreen()|
+  // call.
   //
-  // Passing |forCrossProcessAncestor| to requestFullscreen is necessary
-  // because:
-  // - |ownerElement| will need :-webkit-full-screen-ancestor style in
-  //   addition to :-webkit-full-screen.
-  // - there's no need to resend the ToggleFullscreen IPC to the browser
-  //   process.
+  // PrefixedForCrossProcessDescendant is necessary because:
+  //  - The fullscreen element ready check and other checks should be bypassed.
+  //  - |ownerElement| will need :-webkit-full-screen-ancestor style in addition
+  //    to :-webkit-full-screen.
   //
   // TODO(alexmos): currently, this assumes prefixed requests, but in the
   // future, this should plumb in information about which request type
   // (prefixed or unprefixed) to use for firing fullscreen events.
-  Fullscreen::RequestFullscreen(*owner_element,
-                                Fullscreen::RequestType::kPrefixed,
-                                true /* forCrossProcessAncestor */);
+  Fullscreen::RequestFullscreen(
+      *owner_element,
+      Fullscreen::RequestType::kPrefixedForCrossProcessDescendant);
 }
 
 void WebRemoteFrameImpl::SetHasReceivedUserGesture() {
   GetFrame()->SetDocumentHasReceivedUserGesture();
 }
 
 v8::Local<v8::Object> WebRemoteFrameImpl::GlobalProxy() const {
   return GetFrame()
       ->GetWindowProxy(DOMWrapperWorld::MainWorld())
       ->GlobalProxyIfNotDetached();
 }
 
 WebRemoteFrameImpl::WebRemoteFrameImpl(WebTreeScopeType scope,
                                        WebRemoteFrameClient* client)
     : WebRemoteFrameBase(scope),
       frame_client_(RemoteFrameClientImpl::Create(this)),
       client_(client),
       self_keep_alive_(this) {}
 
 }  // namespace blink