Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(519)

Issue 2855783002: Try #2: Convert android to use X509CertificateBytes instead of X509CertificateOpenSSL. (Closed)

Created:
3 years, 7 months ago by mattm
Modified:
3 years, 7 months ago
Reviewers:
davidben
CC:
chromium-reviews, rsleevi+watch_chromium.org, certificate-transparency-chrome_googlegroups.com, cbentzel+watch_chromium.org, Eran Messeri, net-reviews_chromium.org, martijn+crwatch_martijnc.be
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Try #2: Convert android to use X509CertificateBytes instead of X509CertificateOpenSSL. BUG=671420 TBR=davidben@chromium.org Review-Url: https://codereview.chromium.org/2855783002 Cr-Commit-Position: refs/heads/master@{#468524} Committed: https://chromium.googlesource.com/chromium/src/+/e05a6fdeff3d39f64b4af1d1468251602e9ccc6b

Patch Set 1 : Patch Set 9 from https://codereview.chromium.org/2786173003 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -16 lines) Patch
M net/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M net/socket/ssl_server_socket_impl.cc View 3 chunks +18 lines, -15 lines 0 comments Download
M net/ssl/openssl_client_key_store.cc View 3 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
mattm
The change is even smaller this time due to your changes https://codereview.chromium.org/2824713002 and https://codereview.chromium.org/2816363002. Perf ...
3 years, 7 months ago (2017-05-01 23:54:31 UTC) #5
mattm
(TBRing since this is just a reland of https://codereview.chromium.org/2786173003 minus some changes that are no ...
3 years, 7 months ago (2017-05-02 01:12:45 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2855783002/20001
3 years, 7 months ago (2017-05-02 01:15:44 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/e05a6fdeff3d39f64b4af1d1468251602e9ccc6b
3 years, 7 months ago (2017-05-02 01:20:19 UTC) #14
davidben
3 years, 7 months ago (2017-05-02 06:08:18 UTC) #15
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698