Convert android to use X509CertificateBytes instead of X509CertificateOpenSSL.

Convert android to use X509CertificateBytes instead of X509CertificateOpenSSL.

BUG=671420
Review-Url: https://codereview.chromium.org/2786173003
Cr-Commit-Position: refs/heads/master@{#464262}
Committed: https://chromium.googlesource.com/chromium/src/+/0704d236ee706ffb29fc22fd90f99537e7f15673

[mattm, 2017-03-30 23:27:52]

The CQ bit was checked by mattm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-30 23:29:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-30 23:51:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-30 23:51:41]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[mattm, 2017-03-31 23:02:02]

The CQ bit was checked by mattm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-31 23:03:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-31 23:27:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-31 23:27:42]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[mattm, 2017-04-01 00:45:47]

The CQ bit was checked by mattm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-01 00:46:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mattm, 2017-04-01 01:36:03]

The CQ bit was checked by mattm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-01 01:36:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-01 03:11:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-01 03:11:30]

Dry run: This issue passed the CQ dry run.

[mattm, 2017-04-04 23:36:01]

The CQ bit was checked by mattm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-04 23:37:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-05 01:34:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-05 01:34:06]

Dry run: This issue passed the CQ dry run.

[mattm, 2017-04-07 22:37:15]

The CQ bit was checked by mattm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-07 22:38:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mattm, 2017-04-07 23:09:40]

Description was changed from

==========
*WIP* android X509CertificateBytes

BUG=671420
==========

to

==========
Convert android to use X509CertificateBytes instead of X509CertificateOpenSSL.

BUG=671420
==========

[commit-bot: I haz the power, 2017-04-07 23:29:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-07 23:29:15]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[mattm, 2017-04-11 01:04:23]

The CQ bit was checked by mattm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-11 01:05:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mattm, 2017-04-11 01:18:23]

mattm@chromium.org changed reviewers:
+ davidben@chromium.org

[mattm, 2017-04-11 01:18:24]

Hi David,

If you have time, would you like to look at this to see if this is all good for
getting the important memory savings on android, or if there are any other
places it's worth special casing USE_BYTE_CERTS?  (I didn't want to go too crazy
with spreading around ifdefs for that.)

If you don't have time, feel free to punt the review.

ssl_client_socket_impl.cc was already changed in the parent cl:
https://codereview.chromium.org/2746103003/diff/420001/net/socket/ssl_client_...

[commit-bot: I haz the power, 2017-04-11 01:30:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-11 01:30:44]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[davidben, 2017-04-11 23:42:45]

lgtm, though the CQ currently doesn't like you.

(Wow, I'm impressed the CL is so small.)

https://codereview.chromium.org/2786173003/diff/120001/net/socket/ssl_server_...
File net/socket/ssl_server_socket_impl.cc (right):

https://codereview.chromium.org/2786173003/diff/120001/net/socket/ssl_server_...
net/socket/ssl_server_socket_impl.cc:667: #endif  // USE_OPENSSL_CERTS &&
!USE_BYTE_CERTS
You can simplify this a bit and SSL_CTX_use_certificate_ASN1. (Hrm, we might
want to attach the CRYPTO_BUFFER_POOL to this SSL_CTX. But it doesn't really
matter because this is just used in tests.)

[mattm, 2017-04-12 23:05:32]

The CQ bit was checked by mattm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-12 23:06:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mattm, 2017-04-12 23:07:45]

https://codereview.chromium.org/2786173003/diff/120001/net/socket/ssl_server_...
File net/socket/ssl_server_socket_impl.cc (right):

https://codereview.chromium.org/2786173003/diff/120001/net/socket/ssl_server_...
net/socket/ssl_server_socket_impl.cc:667: #endif  // USE_OPENSSL_CERTS &&
!USE_BYTE_CERTS
On 2017/04/11 23:42:45, davidben wrote:
> You can simplify this a bit and SSL_CTX_use_certificate_ASN1. (Hrm, we might
> want to attach the CRYPTO_BUFFER_POOL to this SSL_CTX. But it doesn't really
> matter because this is just used in tests.)

Updated. Mind taking another look?

[davidben, 2017-04-12 23:11:39]

lgtm

[davidben, 2017-04-12 23:12:32]

+xunjieli FYI. This is the other half of the CRYPTO_BUFFER work on Android as
far as memory usage goes.

[commit-bot: I haz the power, 2017-04-13 00:20:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-13 00:20:17]

Dry run: This issue passed the CQ dry run.

[mattm, 2017-04-13 01:46:12]

The CQ bit was checked by mattm@chromium.org

[commit-bot: I haz the power, 2017-04-13 01:46:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 02:54:34]

CQ is committing da patch.

Bot data: {"patchset_id": 160001, "attempt_start_ts": 1492047972733130,
"parent_rev": "26a99a8103c789a5af8858263bded1cc60d7cb19", "commit_rev":
"0704d236ee706ffb29fc22fd90f99537e7f15673"}

[commit-bot: I haz the power, 2017-04-13 02:55:23]

Description was changed from

==========
Convert android to use X509CertificateBytes instead of X509CertificateOpenSSL.

BUG=671420
==========

to

==========
Convert android to use X509CertificateBytes instead of X509CertificateOpenSSL.

BUG=671420

Review-Url: https://codereview.chromium.org/2786173003
Cr-Commit-Position: refs/heads/master@{#464262}
Committed:
https://chromium.googlesource.com/chromium/src/+/0704d236ee706ffb29fc22fd90f9...
==========

[commit-bot: I haz the power, 2017-04-13 02:55:24]

Committed patchset #9 (id:160001) as
https://chromium.googlesource.com/chromium/src/+/0704d236ee706ffb29fc22fd90f9...

[nednguyen, 2017-04-14 10:50:26]

A revert of this CL (patchset #9 id:160001) has been created in
https://codereview.chromium.org/2817053003/ by nednguyen@google.com.

The reason for reverting is: Suspect causing ERR_SSL_SERVER_CERT_BAD_FORMAT
error on perf tests..