Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Issue 2824713002: Trim some dependencies on crypto/x509 headers. (Closed)

Created:
3 years, 8 months ago by davidben
Modified:
3 years, 8 months ago
Reviewers:
stevenjb, mattm
CC:
chromium-reviews, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, ios-reviews_chromium.org, net-reviews_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Trim some dependencies on crypto/x509 headers. This makes it a bit easier to keep track of what's left. BUG=706445 Review-Url: https://codereview.chromium.org/2824713002 Cr-Commit-Position: refs/heads/master@{#464939} Committed: https://chromium.googlesource.com/chromium/src/+/bdf74a5e0076644d318f7cac67bf0c6c03c89718

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : missing forward decl #

Patch Set 4 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -44 lines) Patch
M chrome/browser/extensions/api/networking_private/networking_private_crypto.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M net/cert/cert_verify_proc_android.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/cert/internal/signature_policy.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/cert/internal/verify_signed_data_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/cert/x509_certificate_ios.cc View 1 1 chunk +9 lines, -0 lines 0 comments Download
M net/quic/test_tools/crypto_test_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/socket/ssl_client_socket_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/ssl/openssl_ssl_util.h View 1 2 2 chunks +1 line, -7 lines 0 comments Download
M net/ssl/openssl_ssl_util.cc View 2 chunks +0 lines, -26 lines 0 comments Download
M net/ssl/ssl_client_session_cache.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M net/ssl/ssl_platform_key_win.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/tools/quic/test_tools/quic_test_client.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 27 (21 generated)
davidben
3 years, 8 months ago (2017-04-16 23:07:34 UTC) #16
mattm
lgtm
3 years, 8 months ago (2017-04-16 23:50:43 UTC) #17
davidben
+stevenjb for networking_private
3 years, 8 months ago (2017-04-17 00:27:57 UTC) #21
stevenjb
lgtm
3 years, 8 months ago (2017-04-17 16:51:50 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2824713002/60001
3 years, 8 months ago (2017-04-17 17:16:24 UTC) #24
commit-bot: I haz the power
3 years, 8 months ago (2017-04-17 17:21:50 UTC) #27
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/bdf74a5e0076644d318f7cac67bf...

Powered by Google App Engine
This is Rietveld 408576698