Don't submit frames with no render passes in cc tests

Don't submit frames with no render passes in cc tests

Now that ForceReclaimResources is gone, frames with no render passes are
only submitted in unit tests. Also, since crrev.com/2835203002 we no
longer allow empty render pass lists to be sent over IPC. Fix the tests 
and remove the checks for empty render pass lists in prod to simplify 
code.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2855723002
Cr-Commit-Position: refs/heads/master@{#469545}
Committed: https://chromium.googlesource.com/chromium/src/+/e8422c6b6f2255f3f6ad8620af456d8eba0cd9d2

[Saman Sami, 2017-05-01 20:38:17]

Description was changed from

==========
Reject empty render_pass_list in CFSS::SubmitCompositorFrame
==========

to

==========
Reject empty render_pass_list in CFSS::SubmitCompositorFrame
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[Saman Sami, 2017-05-01 20:39:04]

The CQ bit was checked by samans@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-01 20:39:40]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Saman Sami, 2017-05-01 21:03:19]

The CQ bit was checked by samans@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-01 21:04:24]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Saman Sami, 2017-05-01 21:18:07]

The CQ bit was checked by samans@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-01 21:19:13]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Saman Sami, 2017-05-01 21:29:34]

Description was changed from

==========
Reject empty render_pass_list in CFSS::SubmitCompositorFrame
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Don't submit frames with no render passes in cc tests

Submitting CompositorFrames with empty render_pass_lists never happens 
in real life. Having to accommodate tests that submit such invalid
frames has introduced unneeded complexity in our code. This CL fixes
unit tests so they don't submit frames with no render passes and also 
removes unnecessary checks throughout the codebase,

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[Saman Sami, 2017-05-01 21:36:25]

Description was changed from

==========
Don't submit frames with no render passes in cc tests

Submitting CompositorFrames with empty render_pass_lists never happens 
in real life. Having to accommodate tests that submit such invalid
frames has introduced unneeded complexity in our code. This CL fixes
unit tests so they don't submit frames with no render passes and also 
removes unnecessary checks throughout the codebase,

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Don't submit frames with no render passes in cc tests

Now that ForceReclaimResources is gone, the only place that a frame
with no render passes can be submitted is unit tests. Fix the tests 
so we can get rid of the code that handles frames with no render passes.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[Saman Sami, 2017-05-01 21:38:57]

Description was changed from

==========
Don't submit frames with no render passes in cc tests

Now that ForceReclaimResources is gone, the only place that a frame
with no render passes can be submitted is unit tests. Fix the tests 
so we can get rid of the code that handles frames with no render passes.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Don't submit frames with no render passes in cc tests

Now that ForceReclaimResources is gone, frames with no render passes are
only submitted in unit tests. Fix the tests so we can get rid of the code 
that handles frames with no render passes.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[Saman Sami, 2017-05-01 21:39:50]

samans@chromium.org changed reviewers:
+ fsamuel@chromium.org

[Saman Sami, 2017-05-01 21:40:08]

PTAL

[Fady Samuel, 2017-05-01 21:45:41]

lgtm

[Saman Sami, 2017-05-01 21:46:02]

samans@chromium.org changed reviewers:
+ danakj@chromium.org

[Saman Sami, 2017-05-01 21:46:17]

danakj: Please review cc.

[danakj, 2017-05-01 22:12:06]

Can you make it more clear in the patch description that this gets rid of prod
code that checked for empty renderpass list? It reads like it's preparing us for
it, not doing it.

Also, can you verify that we'd reject frames from the renderer without any
render passes?

[Saman Sami, 2017-05-01 22:17:41]

Description was changed from

==========
Don't submit frames with no render passes in cc tests

Now that ForceReclaimResources is gone, frames with no render passes are
only submitted in unit tests. Fix the tests so we can get rid of the code 
that handles frames with no render passes.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Don't submit frames with no render passes in cc tests

Now that ForceReclaimResources is gone, frames with no render passes are
only submitted in unit tests. Fix the tests and remove the checks for
empty render pass lists in prod to simplify code.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[Saman Sami, 2017-05-01 22:19:15]

Description was changed from

==========
Don't submit frames with no render passes in cc tests

Now that ForceReclaimResources is gone, frames with no render passes are
only submitted in unit tests. Fix the tests and remove the checks for
empty render pass lists in prod to simplify code.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Don't submit frames with no render passes in cc tests

Now that ForceReclaimResources is gone, frames with no render passes are
only submitted in unit tests. Also, since crrev.com/2835203002 we no
longer allow empty render pass lists to be sent over IPC. Fix the tests 
and remove the checks for empty render pass lists in prod to simplify 
code.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[Saman Sami, 2017-05-01 22:20:46]

On 2017/05/01 22:12:06, danakj wrote:
> Can you make it more clear in the patch description that this gets rid of prod
> code that checked for empty renderpass list? It reads like it's preparing us
for
> it, not doing it.
> 
> Also, can you verify that we'd reject frames from the renderer without any
> render passes?

PTAL. I updated the description. I have already dealt with rejecting empty
render pass lists over IPC in http://crrev.com/2835203002.

[Saman Sami, 2017-05-01 22:20:47]

On 2017/05/01 22:12:06, danakj wrote:
> Can you make it more clear in the patch description that this gets rid of prod
> code that checked for empty renderpass list? It reads like it's preparing us
for
> it, not doing it.
> 
> Also, can you verify that we'd reject frames from the renderer without any
> render passes?

PTAL. I updated the description. I have already dealt with rejecting empty
render pass lists over IPC in http://crrev.com/2835203002.

[danakj, 2017-05-01 22:22:42]

Thanks! LGTM

[Saman Sami, 2017-05-01 22:59:45]

The CQ bit was checked by samans@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-01 22:59:54]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-01 23:25:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-01 23:25:43]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[Saman Sami, 2017-05-02 02:49:43]

The CQ bit was checked by samans@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-02 02:50:02]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-02 03:43:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-02 03:43:05]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Saman Sami, 2017-05-04 23:04:28]

The CQ bit was checked by samans@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-04 23:05:12]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-04 23:09:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-04 23:09:47]

Dry run: Try jobs failed on following builders:
  linux_trusty_blink_rel on master.tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_trusty_blink_rel/b...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Saman Sami, 2017-05-04 23:12:52]

The CQ bit was checked by samans@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-04 23:13:34]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Saman Sami, 2017-05-05 00:21:09]

The CQ bit was unchecked by samans@chromium.org

[Saman Sami, 2017-05-05 00:21:15]

The CQ bit was checked by samans@chromium.org

[Saman Sami, 2017-05-05 00:21:15]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org,
fsamuel@chromium.org
Link to the patchset: https://codereview.chromium.org/2855723002/#ps100001
(title: "c")

[commit-bot: I haz the power, 2017-05-05 00:22:10]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-05 00:29:37]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1493943675080940,
"parent_rev": "2c899c792ecd7fd3c2f0e778f256e919e778d73f", "commit_rev":
"e8422c6b6f2255f3f6ad8620af456d8eba0cd9d2"}

[commit-bot: I haz the power, 2017-05-05 00:30:30]

Description was changed from

==========
Don't submit frames with no render passes in cc tests

Now that ForceReclaimResources is gone, frames with no render passes are
only submitted in unit tests. Also, since crrev.com/2835203002 we no
longer allow empty render pass lists to be sent over IPC. Fix the tests 
and remove the checks for empty render pass lists in prod to simplify 
code.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Don't submit frames with no render passes in cc tests

Now that ForceReclaimResources is gone, frames with no render passes are
only submitted in unit tests. Also, since crrev.com/2835203002 we no
longer allow empty render pass lists to be sent over IPC. Fix the tests 
and remove the checks for empty render pass lists in prod to simplify 
code.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2855723002
Cr-Commit-Position: refs/heads/master@{#469545}
Committed:
https://chromium.googlesource.com/chromium/src/+/e8422c6b6f2255f3f6ad8620af45...
==========

[commit-bot: I haz the power, 2017-05-05 00:30:31]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/e8422c6b6f2255f3f6ad8620af45...