Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Unified Diff: cc/test/compositor_frame_helpers.cc

Issue 2855723002: Don't submit frames with no render passes in cc tests (Closed)
Patch Set: c Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/test/compositor_frame_helpers.h ('k') | cc/test/fake_compositor_frame_sink.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/test/compositor_frame_helpers.cc
diff --git a/cc/test/compositor_frame_helpers.cc b/cc/test/compositor_frame_helpers.cc
index 4cccf85caed05489cfe379e1598ff7c08257e183..23cc993fb8b373fd5db95e10666892b95d6ffd7c 100644
--- a/cc/test/compositor_frame_helpers.cc
+++ b/cc/test/compositor_frame_helpers.cc
@@ -9,10 +9,19 @@ namespace cc {
namespace test {
CompositorFrame MakeCompositorFrame() {
+ CompositorFrame frame = MakeEmptyCompositorFrame();
+ std::unique_ptr<RenderPass> pass = RenderPass::Create();
+ pass->SetNew(1, gfx::Rect(0, 0, 20, 20), gfx::Rect(), gfx::Transform());
+ frame.render_pass_list.push_back(std::move(pass));
+ return frame;
+}
+
+CompositorFrame MakeEmptyCompositorFrame() {
CompositorFrame frame;
frame.metadata.begin_frame_ack.source_id = BeginFrameArgs::kManualSourceId;
frame.metadata.begin_frame_ack.sequence_number =
BeginFrameArgs::kStartingFrameNumber;
+ frame.metadata.device_scale_factor = 1;
return frame;
}
« no previous file with comments | « cc/test/compositor_frame_helpers.h ('k') | cc/test/fake_compositor_frame_sink.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698