Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(505)

Unified Diff: cc/surfaces/surface_manager.cc

Issue 2855723002: Don't submit frames with no render passes in cc tests (Closed)
Patch Set: c Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/surfaces/surface_manager.h ('k') | cc/test/compositor_frame_helpers.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/surfaces/surface_manager.cc
diff --git a/cc/surfaces/surface_manager.cc b/cc/surfaces/surface_manager.cc
index 417b7691ca6a850b49e903fbf747495fc9019768..e4267b4d6baf782c10439b3bd4f3abd5cfc6080e 100644
--- a/cc/surfaces/surface_manager.cc
+++ b/cc/surfaces/surface_manager.cc
@@ -498,19 +498,15 @@ void SurfaceManager::SurfaceReferencesToStringImpl(const SurfaceId& surface_id,
if (surface->HasPendingFrame()) {
// This provides the surface size from the root render pass.
const CompositorFrame& frame = surface->GetPendingFrame();
- if (!frame.render_pass_list.empty()) {
- *str << " pending "
- << frame.render_pass_list.back()->output_rect.size().ToString();
- }
+ *str << " pending "
+ << frame.render_pass_list.back()->output_rect.size().ToString();
}
if (surface->HasActiveFrame()) {
// This provides the surface size from the root render pass.
const CompositorFrame& frame = surface->GetActiveFrame();
- if (!frame.render_pass_list.empty()) {
- *str << " active "
- << frame.render_pass_list.back()->output_rect.size().ToString();
- }
+ *str << " active "
+ << frame.render_pass_list.back()->output_rect.size().ToString();
}
} else {
*str << surface_id;
« no previous file with comments | « cc/surfaces/surface_manager.h ('k') | cc/test/compositor_frame_helpers.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698