Removed the service number member from BaseChildProcessConnection.

Removed the service number member from BaseChildProcessConnection.

In preparation for making the ChildProcessConnection simpler, removing
the service number member from  BaseChildProcessConnection.
It is pertaining to the allocator, not the connection.

Also replaced the LruCache used for the moderate binding pool in
BindingManagerImpl (which was relying on the service number from the
connection) with a LinkedList. It makes the code clearer since we were
only using the LruCache to evict old connections, not the cache part.

BUG=689758
Review-Url: https://codereview.chromium.org/2855323003
Cr-Commit-Position: refs/heads/master@{#469452}
Committed: https://chromium.googlesource.com/chromium/src/+/643ad22bbc6337e430f0108db6f4677499d897e8

[Jay Civelli, 2017-05-03 23:48:58]

The CQ bit was checked by jcivelli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-03 23:49:37]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Jay Civelli, 2017-05-03 23:52:01]

Description was changed from

==========
Removed the slot parameter from BaseChildProcessConnection.

In preparation of making the ChildProcessConnection simpler, removing
the slot paramater from  BaseChildProcessConnection.
This is pertaining to the allocator, not the connection.
Also replaced the LruCache used in the moderate binding pool in
BindingManagerImpl with a LinkedList. It makes the code clearer since
we were only using the LruCache to evict old connections, not the cache
part.

BUG=689758
==========

to

==========
Removed the slot parameter from BaseChildProcessConnection.

In preparation for making the ChildProcessConnection simpler, removing
the service number member from  BaseChildProcessConnection.
It is pertaining to the allocator, not the connection.
Also replaced the LruCache used in the moderate binding pool in
BindingManagerImpl with a LinkedList. It makes the code clearer since
we were only using the LruCache to evict old connections, not the cache
part.

BUG=689758
==========

[Jay Civelli, 2017-05-03 23:52:01]

jcivelli@chromium.org changed reviewers:
+ boliu@chromium.org

[Jay Civelli, 2017-05-03 23:58:13]

Description was changed from

==========
Removed the slot parameter from BaseChildProcessConnection.

In preparation for making the ChildProcessConnection simpler, removing
the service number member from  BaseChildProcessConnection.
It is pertaining to the allocator, not the connection.
Also replaced the LruCache used in the moderate binding pool in
BindingManagerImpl with a LinkedList. It makes the code clearer since
we were only using the LruCache to evict old connections, not the cache
part.

BUG=689758
==========

to

==========
Removed the slot parameter from BaseChildProcessConnection.

In preparation for making the ChildProcessConnection simpler, removing
the service number member from  BaseChildProcessConnection.
It is pertaining to the allocator, not the connection.

Also replaced the LruCache used in the moderate binding pool in
BindingManagerImpl (which was relying on the service number from the
connection) with a LinkedList. It makes the code clearer since we were
only using the LruCache to evict old connections, not the cache part.

BUG=689758
==========

[Jay Civelli, 2017-05-03 23:58:33]

Description was changed from

==========
Removed the slot parameter from BaseChildProcessConnection.

In preparation for making the ChildProcessConnection simpler, removing
the service number member from  BaseChildProcessConnection.
It is pertaining to the allocator, not the connection.

Also replaced the LruCache used in the moderate binding pool in
BindingManagerImpl (which was relying on the service number from the
connection) with a LinkedList. It makes the code clearer since we were
only using the LruCache to evict old connections, not the cache part.

BUG=689758
==========

to

==========
Removed the slot parameter from BaseChildProcessConnection.

In preparation for making the ChildProcessConnection simpler, removing
the service number member from  BaseChildProcessConnection.
It is pertaining to the allocator, not the connection.

Also replaced the LruCache used for the moderate binding pool in
BindingManagerImpl (which was relying on the service number from the
connection) with a LinkedList. It makes the code clearer since we were
only using the LruCache to evict old connections, not the cache part.

BUG=689758
==========

[Jay Civelli, 2017-05-04 00:56:01]

The CQ bit was checked by jcivelli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-04 00:56:29]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-04 01:51:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-04 01:51:35]

Dry run: This issue passed the CQ dry run.

[Jay Civelli, 2017-05-04 15:52:41]

Patchset #1 (id:1) has been deleted

[Jay Civelli, 2017-05-04 16:07:47]

Description was changed from

==========
Removed the slot parameter from BaseChildProcessConnection.

In preparation for making the ChildProcessConnection simpler, removing
the service number member from  BaseChildProcessConnection.
It is pertaining to the allocator, not the connection.

Also replaced the LruCache used for the moderate binding pool in
BindingManagerImpl (which was relying on the service number from the
connection) with a LinkedList. It makes the code clearer since we were
only using the LruCache to evict old connections, not the cache part.

BUG=689758
==========

to

==========
Removed the service number member from BaseChildProcessConnection.

In preparation for making the ChildProcessConnection simpler, removing
the service number member from  BaseChildProcessConnection.
It is pertaining to the allocator, not the connection.

Also replaced the LruCache used for the moderate binding pool in
BindingManagerImpl (which was relying on the service number from the
connection) with a LinkedList. It makes the code clearer since we were
only using the LruCache to evict old connections, not the cache part.

BUG=689758
==========

[boliu, 2017-05-04 18:35:02]

https://codereview.chromium.org/2855323003/diff/20001/content/public/android/...
File
content/public/android/java/src/org/chromium/content/browser/BindingManagerImpl.java
(right):

https://codereview.chromium.org/2855323003/diff/20001/content/public/android/...
content/public/android/java/src/org/chromium/content/browser/BindingManagerImpl.java:44:
private final LinkedList<ManagedConnection> mConnections = new LinkedList<>();
comment this is in LRU order

https://codereview.chromium.org/2855323003/diff/20001/content/public/android/...
content/public/android/java/src/org/chromium/content/browser/BindingManagerImpl.java:131:
int index = mConnections.indexOf(managedConnection);
indexOf + remove requires two iterations of the list... I know it's only 20
items at most, but still.. removeFirstOccurrence?

https://codereview.chromium.org/2855323003/diff/20001/content/public/android/...
content/public/android/java/src/org/chromium/content/browser/BindingManagerImpl.java:139:
mConnections.add(0, managedConnection);
maybe assert at the end size <= mMaxSize?

https://codereview.chromium.org/2855323003/diff/20001/content/public/android/...
File
content/public/android/java/src/org/chromium/content/browser/ChildConnectionAllocator.java
(right):

https://codereview.chromium.org/2855323003/diff/20001/content/public/android/...
content/public/android/java/src/org/chromium/content/browser/ChildConnectionAllocator.java:208:
for (int i = 0; i < mChildProcessConnections.length; i++) {
kinda tedius, how about Array.asList(mChildProcessConnections).indexOf?

https://codereview.chromium.org/2855323003/diff/20001/content/public/android/...
File
content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java
(right):

https://codereview.chromium.org/2855323003/diff/20001/content/public/android/...
content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java:494:
Log.d(TAG, "Setting up connection to process");
can still print something useful with getServiceName?

[Jay Civelli, 2017-05-04 19:31:49]

https://codereview.chromium.org/2855323003/diff/20001/content/public/android/...
File
content/public/android/java/src/org/chromium/content/browser/BindingManagerImpl.java
(right):

https://codereview.chromium.org/2855323003/diff/20001/content/public/android/...
content/public/android/java/src/org/chromium/content/browser/BindingManagerImpl.java:44:
private final LinkedList<ManagedConnection> mConnections = new LinkedList<>();
On 2017/05/04 18:35:02, boliu wrote:
> comment this is in LRU order

Done.

https://codereview.chromium.org/2855323003/diff/20001/content/public/android/...
content/public/android/java/src/org/chromium/content/browser/BindingManagerImpl.java:131:
int index = mConnections.indexOf(managedConnection);
On 2017/05/04 18:35:02, boliu wrote:
> indexOf + remove requires two iterations of the list... I know it's only 20
> items at most, but still.. removeFirstOccurrence?

Good idea, done.

https://codereview.chromium.org/2855323003/diff/20001/content/public/android/...
content/public/android/java/src/org/chromium/content/browser/BindingManagerImpl.java:139:
mConnections.add(0, managedConnection);
On 2017/05/04 18:35:02, boliu wrote:
> maybe assert at the end size <= mMaxSize?

Done.

https://codereview.chromium.org/2855323003/diff/20001/content/public/android/...
File
content/public/android/java/src/org/chromium/content/browser/ChildConnectionAllocator.java
(right):

https://codereview.chromium.org/2855323003/diff/20001/content/public/android/...
content/public/android/java/src/org/chromium/content/browser/ChildConnectionAllocator.java:208:
for (int i = 0; i < mChildProcessConnections.length; i++) {
On 2017/05/04 18:35:02, boliu wrote:
> kinda tedius, how about Array.asList(mChildProcessConnections).indexOf?

Sure.

https://codereview.chromium.org/2855323003/diff/20001/content/public/android/...
File
content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java
(right):

https://codereview.chromium.org/2855323003/diff/20001/content/public/android/...
content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java:494:
Log.d(TAG, "Setting up connection to process");
On 2017/05/04 18:35:02, boliu wrote:
> can still print something useful with getServiceName?

Done.

[Jay Civelli, 2017-05-04 19:31:54]

The CQ bit was checked by jcivelli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-04 19:33:13]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[boliu, 2017-05-04 19:38:53]

lgtm

[commit-bot: I haz the power, 2017-05-04 20:21:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-04 20:21:33]

Dry run: This issue passed the CQ dry run.

[Jay Civelli, 2017-05-04 20:28:44]

The CQ bit was checked by jcivelli@chromium.org

[commit-bot: I haz the power, 2017-05-04 20:29:25]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-04 20:34:05]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1493929724747430,
"parent_rev": "f46f5ae7f57b6333f62cc0442a01550c688dfca1", "commit_rev":
"643ad22bbc6337e430f0108db6f4677499d897e8"}

[commit-bot: I haz the power, 2017-05-04 20:34:19]

Description was changed from

==========
Removed the service number member from BaseChildProcessConnection.

In preparation for making the ChildProcessConnection simpler, removing
the service number member from  BaseChildProcessConnection.
It is pertaining to the allocator, not the connection.

Also replaced the LruCache used for the moderate binding pool in
BindingManagerImpl (which was relying on the service number from the
connection) with a LinkedList. It makes the code clearer since we were
only using the LruCache to evict old connections, not the cache part.

BUG=689758
==========

to

==========
Removed the service number member from BaseChildProcessConnection.

In preparation for making the ChildProcessConnection simpler, removing
the service number member from  BaseChildProcessConnection.
It is pertaining to the allocator, not the connection.

Also replaced the LruCache used for the moderate binding pool in
BindingManagerImpl (which was relying on the service number from the
connection) with a LinkedList. It makes the code clearer since we were
only using the LruCache to evict old connections, not the cache part.

BUG=689758

Review-Url: https://codereview.chromium.org/2855323003
Cr-Commit-Position: refs/heads/master@{#469452}
Committed:
https://chromium.googlesource.com/chromium/src/+/643ad22bbc6337e430f0108db6f4...
==========

[commit-bot: I haz the power, 2017-05-04 20:34:22]

Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/643ad22bbc6337e430f0108db6f4...