Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2347)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ManagedChildProcessConnection.java

Issue 2855323003: Removed the service number member from BaseChildProcessConnection. (Closed)
Patch Set: Minor clean-up Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/java/src/org/chromium/content/browser/ManagedChildProcessConnection.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/ManagedChildProcessConnection.java b/content/public/android/java/src/org/chromium/content/browser/ManagedChildProcessConnection.java
index 9281f3afb1bd91296bfe9efad795a5103403ac6d..05f5364871e177bf03631fd31dee8204fefbc9fe 100644
--- a/content/public/android/java/src/org/chromium/content/browser/ManagedChildProcessConnection.java
+++ b/content/public/android/java/src/org/chromium/content/browser/ManagedChildProcessConnection.java
@@ -21,11 +21,11 @@ public class ManagedChildProcessConnection extends BaseChildProcessConnection {
public static final Factory FACTORY = new BaseChildProcessConnection.Factory() {
@Override
- public BaseChildProcessConnection create(Context context, int number, boolean sandboxed,
+ public BaseChildProcessConnection create(Context context, boolean sandboxed,
DeathCallback deathCallback, String serviceClassName,
Bundle childProcessCommonParameters, ChildProcessCreationParams creationParams) {
assert LauncherThread.runningOnLauncherThread();
- return new ManagedChildProcessConnection(context, number, sandboxed, deathCallback,
+ return new ManagedChildProcessConnection(context, sandboxed, deathCallback,
serviceClassName, childProcessCommonParameters, creationParams);
}
};
@@ -60,11 +60,11 @@ public class ManagedChildProcessConnection extends BaseChildProcessConnection {
private boolean mUnbound;
@VisibleForTesting
- ManagedChildProcessConnection(Context context, int number, boolean sandboxed,
- DeathCallback deathCallback, String serviceClassName,
- Bundle childProcessCommonParameters, ChildProcessCreationParams creationParams) {
- super(context, number, sandboxed, deathCallback, serviceClassName,
- childProcessCommonParameters, creationParams);
+ ManagedChildProcessConnection(Context context, boolean sandboxed, DeathCallback deathCallback,
+ String serviceClassName, Bundle childProcessCommonParameters,
+ ChildProcessCreationParams creationParams) {
+ super(context, sandboxed, deathCallback, serviceClassName, childProcessCommonParameters,
+ creationParams);
int initialFlags = Context.BIND_AUTO_CREATE;
int extraBindFlags = shouldBindAsExportedService() ? Context.BIND_EXTERNAL_SERVICE : 0;

Powered by Google App Engine
This is Rietveld 408576698