Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Unified Diff: content/public/android/junit/src/org/chromium/content/browser/BindingManagerImplTest.java

Issue 2855323003: Removed the service number member from BaseChildProcessConnection. (Closed)
Patch Set: Minor clean-up Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/junit/src/org/chromium/content/browser/BindingManagerImplTest.java
diff --git a/content/public/android/junit/src/org/chromium/content/browser/BindingManagerImplTest.java b/content/public/android/junit/src/org/chromium/content/browser/BindingManagerImplTest.java
index 42578238305513ab3cb7e24e3ef3b90c16606d7e..dad88d10646eac4f579a4bd379b52ca70666304f 100644
--- a/content/public/android/junit/src/org/chromium/content/browser/BindingManagerImplTest.java
+++ b/content/public/android/junit/src/org/chromium/content/browser/BindingManagerImplTest.java
@@ -67,9 +67,8 @@ public class BindingManagerImplTest {
* connection is established: with initial binding bound and no strong binding.
*/
private TestChildProcessConnection(int pid) {
- super(null /* context */, pid /* number */, true /* sandboxed */,
- null /* deathCallback */, null /* serviceClassName */,
- null /* childProcessCommonParameters */,
+ super(null /* context */, true /* sandboxed */, null /* deathCallback */,
+ "TestService" /* serviceClassName */, null /* childProcessCommonParameters */,
new ChildProcessCreationParams("org.chromium.test",
false /* isExternalService */, 0 /* libraryProcessType */,
false /* bindToCallerCheck */));
@@ -566,7 +565,7 @@ public class BindingManagerImplTest {
}
app.onTrimMemory(pair.first);
- // Verify that some of moderate bindings drop.
+ // Verify that some of the moderate bindings have been dropped.
for (int i = 0; i < connections.length; i++) {
Assert.assertEquals(
message, i >= pair.second, connections[i].isModerateBindingBound());

Powered by Google App Engine
This is Rietveld 408576698