Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Unified Diff: third_party/WebKit/Source/core/frame/Window.idl

Issue 2855263004: Throw in window.open() when an invalid URL is being passed (Closed)
Patch Set: updates Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/Window.idl
diff --git a/third_party/WebKit/Source/core/frame/Window.idl b/third_party/WebKit/Source/core/frame/Window.idl
index 2bbfaa865627a17625dfbc751ada0eb494480289..015c9b4c6371d9cc2bc9b34fe55b0e6c0eb5b9e3 100644
--- a/third_party/WebKit/Source/core/frame/Window.idl
+++ b/third_party/WebKit/Source/core/frame/Window.idl
@@ -63,7 +63,7 @@
[Replaceable, CrossOrigin] readonly attribute Window? parent;
[CheckSecurity=ReturnValue, Custom=Getter] readonly attribute Element? frameElement;
// FIXME: open() should have 4 optional arguments with defaults.
- [Custom] Window? open(DOMString url, DOMString target, optional DOMString features);
+ [Custom, RaisesException] Window? open(DOMString url, DOMString target, optional DOMString features);
foolip 2017/05/05 11:21:29 FYI, I wondered if returning null is still possibl
jochen (gone - plz use gerrit) 2017/05/05 11:25:51 correct, that should return null. Also note that t
foolip 2017/05/05 11:28:55 Yeah, just verifying since sometimes the exception
// indexed properties
// https://html.spec.whatwg.org/C/browsers.html#windowproxy-getownproperty

Powered by Google App Engine
This is Rietveld 408576698