Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Unified Diff: third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp

Issue 2855263004: Throw in window.open() when an invalid URL is being passed (Closed)
Patch Set: updates Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp
diff --git a/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp b/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp
index ba0b0ce0bf196686fb94ad892b83380edf65a445..04cdda8a49a67477a3edc448e511236e4f18ebe8 100644
--- a/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp
+++ b/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp
@@ -1609,7 +1609,8 @@ DOMWindow* LocalDOMWindow::open(const String& url_string,
const AtomicString& frame_name,
const String& window_features_string,
LocalDOMWindow* calling_window,
- LocalDOMWindow* entered_window) {
+ LocalDOMWindow* entered_window,
+ ExceptionState& exception_state) {
if (!IsCurrentlyDisplayedInFrame())
return nullptr;
if (!calling_window->GetFrame())
@@ -1667,7 +1668,7 @@ DOMWindow* LocalDOMWindow::open(const String& url_string,
WindowFeatures features(window_features_string);
DOMWindow* new_window =
CreateWindow(url_string, frame_name, features, *calling_window,
- *first_frame, *GetFrame());
+ *first_frame, *GetFrame(), exception_state);
return features.noopener ? nullptr : new_window;
}

Powered by Google App Engine
This is Rietveld 408576698